Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/2] sql: show varbinary in type mismatch error
Date: Thu, 24 Jun 2021 22:24:34 +0200	[thread overview]
Message-ID: <3b40d57f-5051-418c-5899-9aa241114c57@tarantool.org> (raw)
In-Reply-To: <eb4c75bb83aba24a70318074b6710362a67e9e9c.1624530339.git.imeevma@gmail.com>

Hi! Thanks for the patchset!

> diff --git a/test/sql-tap/uuid.test.lua b/test/sql-tap/uuid.test.lua
> index 77ba06c2d..f19eb4a9c 100755
> --- a/test/sql-tap/uuid.test.lua
> +++ b/test/sql-tap/uuid.test.lua
> @@ -697,7 +697,7 @@ test:do_catchsql_test(
>      [[
>          SELECT cast(randomblob(10) as UUID) FROM t2 LIMIT 1;
>      ]], {
> -        1, "Type mismatch: can not convert varbinary to uuid"
> +        1, "Type mismatch: can not convert x'819192E578DE3FA24AF3' to uuid"

randomblob() can return different results from time to time. I
would not check for the exact error message.

Now it somewhy returns the same values, but I suppose that might
change. The same below.

>      })
>  
>  test:execsql([[
> @@ -858,7 +858,7 @@ test:do_catchsql_test(
>      [[
>          INSERT INTO tsu VALUES ('8_varbinary', randomblob(10));
>      ]], {
> -        1, "Type mismatch: can not convert varbinary to uuid"
> +        1, "Type mismatch: can not convert x'733CA8769291A0FEE366' to uuid"
>      })

  reply	other threads:[~2021-06-24 20:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 10:30 [Tarantool-patches] [PATCH v1 0/2] sql: fix description of " Mergen Imeev via Tarantool-patches
2021-06-24 10:30 ` [Tarantool-patches] [PATCH v1 1/2] sql: show varbinary in " Mergen Imeev via Tarantool-patches
2021-06-24 20:24   ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-06-24 10:30 ` [Tarantool-patches] [PATCH v1 2/2] sql: always show value " Mergen Imeev via Tarantool-patches
2021-06-25  7:27   ` Kirill Yukhin via Tarantool-patches
     [not found]     ` <114901d769ab$431961e0$c94c25a0$@tarantool.org>
2021-06-25 10:46       ` Mergen Imeev via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b40d57f-5051-418c-5899-9aa241114c57@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 1/2] sql: show varbinary in type mismatch error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox