From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6CE286EC58; Fri, 25 Jun 2021 13:46:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6CE286EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624617983; bh=dihlPwhaD6YBQRlFbO/MRaiNqRPW7qLZiER9aOJzb5I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fabeffK3pbI8rrtJkoYPbHMB7fBQWaao8aYvPljPGr2INKfXQf18xwm3gFKOHscVr ZhNJgTMHUUit6fDQa6iwk2JFJYhrj7fCjGBZKXo5uEo2uJ5ZIQ3lK9iiwqHhzEfti0 n6gMS282/ey2Lhii7spbhItrmKTYx8fiZ9w6ey84= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 406F96EC58 for ; Fri, 25 Jun 2021 13:46:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 406F96EC58 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lwjLo-0001pQ-UP; Fri, 25 Jun 2021 13:46:21 +0300 Date: Fri, 25 Jun 2021 13:46:19 +0300 To: Timur Safin Message-ID: <20210625104619.GA97325@tarantool.org> References: <20210625072724.3lc35g67i5t3c5ew@tarantool.org> <114901d769ab$431961e0$c94c25a0$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <114901d769ab$431961e0$c94c25a0$@tarantool.org> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB0C620705B15DE32DFE392EA95FA71EAB182A05F5380850405FB66BB7435508337790AF0C911F1A2BF8D370EF155EFBC23D300DF660B1109F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E50EC9128971FD6EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637204D59D994DFFAD78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84D2A1B0CD088DA932EE2B7717ADE37A6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B66F6A3E018CF4DC80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5551C804022A63C778CC96562174EACBFA7C6B4CA05D7314CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C2BE7381A0AD3DF107257C6E8B046F22F474A3FA2E17B7DE6CC1C5ACC8273659FA3CEB7DD0C859231D7E09C32AA3244C0B8EAB43A7C14E0FC41DF3E4D722282851E887DA02A9F7BF927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQMwavxIrnHYs9qJOaaiuqw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822DA28EA64E99B16CDD1326FE5A992CE6483D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 2/2] sql: always show value in type mismatch error X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for your suggestions. My answers below. On Fri, Jun 25, 2021 at 01:17:10PM +0300, Timur Safin wrote: > : From: Kirill Yukhin via Tarantool-patches > : Subject: Re: [Tarantool-patches] [PATCH v1 2/2] sql: always show value in > : type mismatch error > : > : Hello, > : > : On 24 Jun 13:30, Mergen Imeev via Tarantool-patches wrote: > : > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > : > -- Check interaction of BOOLEAN and TEXT. > : > @@ -5272,124 +5272,124 @@ SELECT a2, d, d OR a2 FROM t6, t9; > : > SELECT true > 'abc'; > : > | --- > : > | - null > : > - | - 'Type mismatch: can not convert text to boolean' > : > + | - 'Type mismatch: can not convert abc to boolean' > : > : Is it possible to quote string values (like you do for varbinary)? Yes, it is possible. I will make a patch. > : > : -- > : Regards, Kirill Yukhin > > Yep, agree with Kirill here - it would be more > distinguishable if textual literals (or UUID) > would be properly quoted. > > Also, I assume that reporting original type was useful > as well. So, if possible, it would be ideally if both > values and their types would be reported, e.g. > > > @@ -5272,124 +5272,124 @@ SELECT a2, d, d OR a2 FROM t6, t9; > > SELECT true > 'abc'; > > | --- > > | - null > > - | - 'Type mismatch: can not convert text to boolean' > > + | - 'Type mismatch: can not convert text ("abc") to boolean' > > > Best Regards, > Timur > Ok. However, since this patch-set is now too large for an already closed issue, I will make a new issue. In this issue, I will describe what changes I plan to make. Also, Timur please do not remove tarantool-patches@dev.tarantool.org from your answers.