Re: [Tarantool-patches] [PATCH luajit 0/4] Fix LuaJIT tests on aarch64, odroid

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

Thanks for the series!

On 24.05.21, Sergey Kaplun wrote:
> This patchset fixes failing tests on odroid, aarch64.
> 
> Branch:
> https://github.com/tarantool/luajit/tree/skaplun/gh-6084-missed-carg1-in-bctsetr-fallback
> 
> Test branch:
> https://github.com/tarantool/tarantool/tree/skaplun/gh-6084-missed-carg1-in-bctsetr-fallback
> 
> Issues:
> * https://github.com/tarantool/tarantool/issues/5629
> * https://github.com/tarantool/tarantool/issues/6084
> * https://github.com/tarantool/tarantool/issues/6093
> 
> Honestly, I've failed to find a corresponding issue related to the first
> patch neither in the issue tracker, nor in the LuaJIT ML, so I've only
> referenced the original commit in the #6084.
> 
> For last two patches I don't add a new test case, because it is
> literally the same as the test in lua-Harness suite <301-basic.t:832>.

I guess this is not a problem at all, considering the fact Francois is
mentioned in the second patch. Unfortunately, the assertion you are
talking about is introduced within the "big bang" commit[1] with "some
tests" added, so I see no reason to refer such a huge changeset.

> 
> Mike Pall (3):
>   ARM, ARM64, PPC: Fix TSETR fallback.
>   ARM64: Fix xpcall() error case.
>   ARM64: Fix xpcall() error case (really).
> 
> Sergey Kaplun (1):
>   test: add skipcond on architectures for memprof
> 
>  src/vm_arm.dasc                               |  1 +
>  src/vm_arm64.dasc                             |  6 +++--
>  src/vm_ppc.dasc                               |  1 +
>  test/tarantool-tests/CMakeLists.txt           |  9 ++++---
>  ...-missed-carg1-in-bctsetr-fallback.test.lua | 25 +++++++++++++++++++
>  .../misclib-memprof-lapi.test.lua             |  6 +++++
>  test/tarantool-tests/utils.lua                | 22 ++++++++++++++++
>  7 files changed, 64 insertions(+), 6 deletions(-)
>  create mode 100644 test/tarantool-tests/gh-6084-missed-carg1-in-bctsetr-fallback.test.lua
> 
> -- 
> 2.31.0
> 

[1]: https://framagit.org/fperrad/lua-Harness/-/commit/48964e0

-- 
Best regards,
IM