Re: [Tarantool-patches] [PATCH v1 1/2] sql: VARBINARY result for C functions

[Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi! Thank you for the review. My answer and diffs below.

On Fri, May 28, 2021 at 11:05:05PM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> > diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua
> > new file mode 100755
> > index 000000000..90d09b497
> > --- /dev/null
> > +++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua
> 
> Would be good to do a cleanup and remove the functions before the
> test ends. The same in the next commit.
Fixed.

First diff:

diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua
index 90d09b497..7a748c0eb 100755
--- a/test/sql-tap/gh-6024-funcs-return-bin.test.lua
+++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua
@@ -50,4 +50,8 @@ test:do_execsql_test(
         "varbinary"
     })
 
+box.schema.func.drop("gh-6024-funcs-return-bin.ret_bin")
+box.schema.func.drop("gh-6024-funcs-return-bin.ret_uuid")
+box.schema.func.drop("gh-6024-funcs-return-bin.ret_decimal")
+
 test:finish_test()


Second diff:

diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua
index f0c009679..ee3838fa9 100755
--- a/test/sql-tap/gh-6024-funcs-return-bin.test.lua
+++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua
@@ -85,5 +85,7 @@ test:do_execsql_test(
 box.schema.func.drop("gh-6024-funcs-return-bin.ret_bin")
 box.schema.func.drop("gh-6024-funcs-return-bin.ret_uuid")
 box.schema.func.drop("gh-6024-funcs-return-bin.ret_decimal")
+box.schema.func.drop("get_uuid")
+box.schema.func.drop("get_decimal")
 
 test:finish_test()