From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1 1/2] sql: VARBINARY result for C functions Date: Mon, 31 May 2021 13:18:59 +0300 [thread overview] Message-ID: <20210531101859.GA104537@tarantool.org> (raw) In-Reply-To: <ac9d74e8-55dd-d2f9-0c6c-21e4917ec657@tarantool.org> Hi! Thank you for the review. My answer and diffs below. On Fri, May 28, 2021 at 11:05:05PM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > > diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua > > new file mode 100755 > > index 000000000..90d09b497 > > --- /dev/null > > +++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua > > Would be good to do a cleanup and remove the functions before the > test ends. The same in the next commit. Fixed. First diff: diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua index 90d09b497..7a748c0eb 100755 --- a/test/sql-tap/gh-6024-funcs-return-bin.test.lua +++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua @@ -50,4 +50,8 @@ test:do_execsql_test( "varbinary" }) +box.schema.func.drop("gh-6024-funcs-return-bin.ret_bin") +box.schema.func.drop("gh-6024-funcs-return-bin.ret_uuid") +box.schema.func.drop("gh-6024-funcs-return-bin.ret_decimal") + test:finish_test() Second diff: diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua index f0c009679..ee3838fa9 100755 --- a/test/sql-tap/gh-6024-funcs-return-bin.test.lua +++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua @@ -85,5 +85,7 @@ test:do_execsql_test( box.schema.func.drop("gh-6024-funcs-return-bin.ret_bin") box.schema.func.drop("gh-6024-funcs-return-bin.ret_uuid") box.schema.func.drop("gh-6024-funcs-return-bin.ret_decimal") +box.schema.func.drop("get_uuid") +box.schema.func.drop("get_decimal") test:finish_test()
next prev parent reply other threads:[~2021-05-31 10:19 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-28 11:41 [Tarantool-patches] [PATCH v1 0/2] sql: VARBINARY result for user-defined functions Mergen Imeev via Tarantool-patches 2021-05-28 11:41 ` [Tarantool-patches] [PATCH v1 1/2] sql: VARBINARY result for C functions Mergen Imeev via Tarantool-patches 2021-05-28 21:05 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-31 10:18 ` Mergen Imeev via Tarantool-patches [this message] 2021-05-28 11:41 ` [Tarantool-patches] [PATCH v1 2/2] sql: VARBINARY result for LUA functions Mergen Imeev via Tarantool-patches 2021-06-01 21:44 ` [Tarantool-patches] [PATCH v1 0/2] sql: VARBINARY result for user-defined functions Vladislav Shpilevoy via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210531101859.GA104537@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imeevma@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 1/2] sql: VARBINARY result for C functions' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox