From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DB13E6EC40; Mon, 31 May 2021 13:19:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DB13E6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622456343; bh=quHbF59eKk+GV5ZI7Y8VHuqDgmmyHWwSC/zZZfkHfwQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=yxvYHUCKN7nEa91l/q2wBjX0wMyHxYcR6Fml/HNdf4h7Nohu3oN14uS6kOzkmJWPu +kds4QJG8WJ/ozi0IQeWiE/BxAtOreL3k01XCt2J0q0ntnNk+j6TdOn2uMGGSj/a2h KtHVzivcow9gEVShjNJPBLJssEcKaJ81AnfDU3Qo= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0863C6EC40 for ; Mon, 31 May 2021 13:19:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0863C6EC40 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lnf0f-0006aV-0H; Mon, 31 May 2021 13:19:01 +0300 Date: Mon, 31 May 2021 13:18:59 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210531101859.GA104537@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C5423CDB5763716BB867A249A0077715520182A05F538085040A5A0565DF178174183254A72ACA4512885ADC84D8DFFF3962D99F150DBF76312 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C8F626AC60F7C593C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE73870E1FF9A049D91EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BD6CF32B5F8F9D404C8BAF29DA183B426D761EA3EB3C3F21DCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDC0F6C5B2EEF3D0C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5920E113B79F2EC4D46C5E873150826CFBDCEBA6498EE1E4FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759F66ED85EB5F25FD410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AE88D5ADEBE7C9839AA9A675F45024FACA1FDED40A61E74501672C3BAC0B8CA2557035C8B1B090E71D7E09C32AA3244CF63DD449AD892723A02E887F3B01B1DC3A92A9747B6CC886729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfSv0pR8QZoQoTL5IctPDNQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382292D7F95074FCA7D5C14E1687DF4B1F2983D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/2] sql: VARBINARY result for C functions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the review. My answer and diffs below. On Fri, May 28, 2021 at 11:05:05PM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > > diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua > > new file mode 100755 > > index 000000000..90d09b497 > > --- /dev/null > > +++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua > > Would be good to do a cleanup and remove the functions before the > test ends. The same in the next commit. Fixed. First diff: diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua index 90d09b497..7a748c0eb 100755 --- a/test/sql-tap/gh-6024-funcs-return-bin.test.lua +++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua @@ -50,4 +50,8 @@ test:do_execsql_test( "varbinary" }) +box.schema.func.drop("gh-6024-funcs-return-bin.ret_bin") +box.schema.func.drop("gh-6024-funcs-return-bin.ret_uuid") +box.schema.func.drop("gh-6024-funcs-return-bin.ret_decimal") + test:finish_test() Second diff: diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua index f0c009679..ee3838fa9 100755 --- a/test/sql-tap/gh-6024-funcs-return-bin.test.lua +++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua @@ -85,5 +85,7 @@ test:do_execsql_test( box.schema.func.drop("gh-6024-funcs-return-bin.ret_bin") box.schema.func.drop("gh-6024-funcs-return-bin.ret_uuid") box.schema.func.drop("gh-6024-funcs-return-bin.ret_decimal") +box.schema.func.drop("get_uuid") +box.schema.func.drop("get_decimal") test:finish_test()