From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/2] sql: VARBINARY result for C functions
Date: Fri, 28 May 2021 23:05:05 +0200 [thread overview]
Message-ID: <ac9d74e8-55dd-d2f9-0c6c-21e4917ec657@tarantool.org> (raw)
In-Reply-To: <c8e30d5d1bb383133de4442a545456bdce0bd231.1622201982.git.imeevma@gmail.com>
Hi! Thanks for the patch!
> diff --git a/test/sql-tap/gh-6024-funcs-return-bin.test.lua b/test/sql-tap/gh-6024-funcs-return-bin.test.lua
> new file mode 100755
> index 000000000..90d09b497
> --- /dev/null
> +++ b/test/sql-tap/gh-6024-funcs-return-bin.test.lua
Would be good to do a cleanup and remove the functions before the
test ends. The same in the next commit.
next prev parent reply other threads:[~2021-05-28 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 11:41 [Tarantool-patches] [PATCH v1 0/2] sql: VARBINARY result for user-defined functions Mergen Imeev via Tarantool-patches
2021-05-28 11:41 ` [Tarantool-patches] [PATCH v1 1/2] sql: VARBINARY result for C functions Mergen Imeev via Tarantool-patches
2021-05-28 21:05 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-05-31 10:18 ` Mergen Imeev via Tarantool-patches
2021-05-28 11:41 ` [Tarantool-patches] [PATCH v1 2/2] sql: VARBINARY result for LUA functions Mergen Imeev via Tarantool-patches
2021-06-01 21:44 ` [Tarantool-patches] [PATCH v1 0/2] sql: VARBINARY result for user-defined functions Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac9d74e8-55dd-d2f9-0c6c-21e4917ec657@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/2] sql: VARBINARY result for C functions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox