Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] test_run:wait_log - drop redundant assert
Date: Thu, 27 May 2021 00:47:51 +0300
Message-ID: <20210526214751.qmvs3vdu2holiicn@tkn_work_nb> (raw)
In-Reply-To: <20210325132933.1992678-1-gorcunov@gmail.com>

Sorry for the late response.

LGTM. Thank you!

I resend it as [1] to don't push into master silently: our QA team
should know about changes in test-run.

I added a couple of words how it appears that the unnecessary assert is
placed here.

[1]: https://github.com/tarantool/test-run/pull/306

WBR, Alexander Turenko.

On Thu, Mar 25, 2021 at 04:29:33PM +0300, Cyrill Gorcunov wrote:
> The callee wait_cond does setup timeout by self in case if not provided
> 
>  | local function wait_cond(self, cond, timeout, delay)
>  |     ...
>  |     local timeout = timeout or 60
>  |     ...
>  | end
>  |
>  | local function wait_log(self, node, what, bytes, timeout, opts)
>  |     ...
>  |     return wait_cond(self, cond, timeout, delay)
>  | end
> 
> so no need to verify if timeout is provided in wait_log args.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>  test_run.lua | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/test_run.lua b/test_run.lua
> index 5c29ec9..9e95402 100644
> --- a/test_run.lua
> +++ b/test_run.lua
> @@ -426,7 +426,6 @@ end
>  -- Wrapper for grep_log, wait until expected log entry is appear
>  -- in a server log file.
>  local function wait_log(self, node, what, bytes, timeout, opts)
> -    assert(timeout ~= nil)
>  
>      local opts = opts or {}
>      local delay = opts.delay
> -- 
> 2.30.2
> 

      reply	other threads:[~2021-05-26 21:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 13:29 Cyrill Gorcunov via Tarantool-patches
2021-05-26 21:47 ` Alexander Turenko via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526214751.qmvs3vdu2holiicn@tkn_work_nb \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=gorcunov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git