From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AAC976EC58; Thu, 27 May 2021 00:47:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AAC976EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622065677; bh=Ibgrfbm+UdTvC8zAZuLl7WeCBBzr5B0/iQIqA83cOf4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=u1R8Uoy/fO8RoAB2Hekql7ZF7zQnVSp+UuPLYRHgVtZggI6QjS1p8SbMPEJ8Ducks N800162fBVpZLmH4ipdcZv80symE4mA+apl3qJ+eLyerdqig4cpNKnwQySUI8nCeo8 sZUg7gjoGY3jv+uv51OeiEjmaEJLlgaEzubjSPD8= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B52936EC58 for ; Thu, 27 May 2021 00:47:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B52936EC58 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1lm1Nb-0001dD-T1; Thu, 27 May 2021 00:47:56 +0300 Date: Thu, 27 May 2021 00:47:51 +0300 To: Cyrill Gorcunov Message-ID: <20210526214751.qmvs3vdu2holiicn@tkn_work_nb> References: <20210325132933.1992678-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210325132933.1992678-1-gorcunov@gmail.com> X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9157EECD0FDB90B9A60631225C742FB44676004EC60CDF90400894C459B0CD1B95FF0ED72A184F77A93EED5FD181054BC8279671D2D77756A68897FC172A4A22D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE782A779A89F7D69B2C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE746D93DAA4671895CEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BD6CF32B5F8F9D40422FE214D65F01D5A18A72ED2EA22CBCDCC7F00164DA146DAFE8445B8C89999728AA50765F79006377C70927E34808485389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC817119E5299B287EEF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CD6760E474F0469B4302FCEF25BFAB3454AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C37B54EC8B300660F2BA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE760D144E5727D8455731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4ADE45409D4D0AA00EBB8A76FB47C9B45B9 X-C1DE0DAB: 0D63561A33F958A5E29A8F4554D3297AE7793BC88B5A55B5E7C3110E25A69DADD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752FA4FC647EE431D9410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F1757F8DFBC5C33223A2D848F63BA0FF2900FA536A1DF3C297E450D1802D699C3C5D8452E863ACE1D7E09C32AA3244C4EDD7A37246A0A3E475F7CE6E143C9FA33C9DC155518937F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiWl9RlzdedkOWMvSlJjHYw== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADE5FF0ED72A184F77A93EED5FD181054BCB7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] test_run:wait_log - drop redundant assert X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sorry for the late response. LGTM. Thank you! I resend it as [1] to don't push into master silently: our QA team should know about changes in test-run. I added a couple of words how it appears that the unnecessary assert is placed here. [1]: https://github.com/tarantool/test-run/pull/306 WBR, Alexander Turenko. On Thu, Mar 25, 2021 at 04:29:33PM +0300, Cyrill Gorcunov wrote: > The callee wait_cond does setup timeout by self in case if not provided > > | local function wait_cond(self, cond, timeout, delay) > | ... > | local timeout = timeout or 60 > | ... > | end > | > | local function wait_log(self, node, what, bytes, timeout, opts) > | ... > | return wait_cond(self, cond, timeout, delay) > | end > > so no need to verify if timeout is provided in wait_log args. > > Signed-off-by: Cyrill Gorcunov > --- > test_run.lua | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/test_run.lua b/test_run.lua > index 5c29ec9..9e95402 100644 > --- a/test_run.lua > +++ b/test_run.lua > @@ -426,7 +426,6 @@ end > -- Wrapper for grep_log, wait until expected log entry is appear > -- in a server log file. > local function wait_log(self, node, what, bytes, timeout, opts) > - assert(timeout ~= nil) > > local opts = opts or {} > local delay = opts.delay > -- > 2.30.2 >