From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [Tarantool-patches] [PATCH] test_run:wait_log - drop redundant assert
Date: Thu, 25 Mar 2021 16:29:33 +0300 [thread overview]
Message-ID: <20210325132933.1992678-1-gorcunov@gmail.com> (raw)
The callee wait_cond does setup timeout by self in case if not provided
| local function wait_cond(self, cond, timeout, delay)
| ...
| local timeout = timeout or 60
| ...
| end
|
| local function wait_log(self, node, what, bytes, timeout, opts)
| ...
| return wait_cond(self, cond, timeout, delay)
| end
so no need to verify if timeout is provided in wait_log args.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
test_run.lua | 1 -
1 file changed, 1 deletion(-)
diff --git a/test_run.lua b/test_run.lua
index 5c29ec9..9e95402 100644
--- a/test_run.lua
+++ b/test_run.lua
@@ -426,7 +426,6 @@ end
-- Wrapper for grep_log, wait until expected log entry is appear
-- in a server log file.
local function wait_log(self, node, what, bytes, timeout, opts)
- assert(timeout ~= nil)
local opts = opts or {}
local delay = opts.delay
--
2.30.2
next reply other threads:[~2021-03-25 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 13:29 Cyrill Gorcunov via Tarantool-patches [this message]
2021-05-26 21:47 ` Alexander Turenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325132933.1992678-1-gorcunov@gmail.com \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH] test_run:wait_log - drop redundant assert' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox