From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 0/2] sql: ignore \0 in string passed to user function
Date: Fri, 2 Apr 2021 07:55:07 +0000 [thread overview]
Message-ID: <20210402075507.flihuhed4xfrnbwy@tarantool.org> (raw)
In-Reply-To: <cover.1617101707.git.imeevma@gmail.com>
Hello,
On 30 мар 14:21, Mergen Imeev via Tarantool-patches wrote:
> Currently, string passed to user-defined function from SQL can be cropped in
> case it contains '\0'. This patch-set fixes this behaviour.
>
> https://github.com/tarantool/tarantool/issues/5938
> https://github.com/tarantool/tarantool/tree/imeevma/gh-5938-wrong-string-length
>
> Mergen Imeev (2):
> sql: ignore \0 in string passed to C-function
> sql: ignore \0 in string passed to Lua-function
>
> src/box/sql/func.c | 6 ++-
> test/CMakeLists.txt | 1 +
> test/sql-tap/CMakeLists.txt | 2 +
> test/sql-tap/gh-5938-wrong-string-length.c | 42 +++++++++++++++++
> .../gh-5938-wrong-string-length.test.lua | 45 +++++++++++++++++++
> 5 files changed, 94 insertions(+), 2 deletions(-)
> create mode 100644 test/sql-tap/CMakeLists.txt
> create mode 100644 test/sql-tap/gh-5938-wrong-string-length.c
> create mode 100755 test/sql-tap/gh-5938-wrong-string-length.test.lua
LGTM.
I've checked your patchset into 2.6, 2.7 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2021-04-02 7:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 11:21 Mergen Imeev via Tarantool-patches
2021-03-30 11:21 ` [Tarantool-patches] [PATCH v1 1/2] sql: ignore \0 in string passed to C-function Mergen Imeev via Tarantool-patches
2021-03-31 20:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-01 8:32 ` Mergen Imeev via Tarantool-patches
2021-03-30 11:21 ` [Tarantool-patches] [PATCH v1 2/2] sql: ignore \0 in string passed to Lua-function Mergen Imeev via Tarantool-patches
2021-03-31 20:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-01 8:41 ` Mergen Imeev via Tarantool-patches
2021-04-01 12:01 ` Mergen Imeev via Tarantool-patches
2021-04-01 19:51 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-01 22:50 ` Mergen Imeev via Tarantool-patches
2021-04-01 23:09 ` [Tarantool-patches] [PATCH v1 0/2] sql: ignore \0 in string passed to user function Vladislav Shpilevoy via Tarantool-patches
2021-04-02 7:55 ` Kirill Yukhin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402075507.flihuhed4xfrnbwy@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 0/2] sql: ignore \0 in string passed to user function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox