From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 04BCE6EC5D; Fri, 2 Apr 2021 10:55:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 04BCE6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617350114; bh=GTtO4mOLq/N55PHBfNEog4J33nzzB+WkhcC1PR5VTjk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=BkZDVqpNUcjCKKVDZ+jjU2WLvBN80RX5pEEEumJXlOITkzj4Hlt2qr5gkhZ5ubGCT izYinNMmwub4cslh7H4+QhQTVmUvXeGIqz4sjLBCdpzIXE4p1lkaK+IwSpF5FNpS28 pcDVXCPlWHY6K1HhU7EkyR0zhmV1FfaHtIgeztXQ= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2DFBE6EC5D for ; Fri, 2 Apr 2021 10:55:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2DFBE6EC5D Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1lSEe7-0002tZ-0t; Fri, 02 Apr 2021 10:55:11 +0300 Date: Fri, 2 Apr 2021 07:55:07 +0000 To: imeevma@tarantool.org Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: <20210402075507.flihuhed4xfrnbwy@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA70927CAA5B950F38D9F182A05F538085040F6576C330148F4434C64E0B158D1342A5D689E7D5A7B7637142629AA6E676541 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70312E9A300D47E3BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370F98874192B1BA168638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CF435A971D71E106CB47C15F5147D37A5BA471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658359CC434672EE6371117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF70208BAAE3890E26BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B64438377902865F7D76E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C143E5F3B0A4B3DFD43847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D6C35EE8C2B984D9D355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A5188F8F79E5251551B6046F5BB45F4E2CAD639258B582DF9FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34BF5454112BD5BFD770DC2201CEF348425E36C62A343CA90641F2E01B617CF3628565CB678D45A4D31D7E09C32AA3244C36B9BF6F2048B93C29C4A88B0388B690BBA718C7E6A9E042FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf334ocUdkYtmujw== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD20B5BC1859A5D1F2A84DB2A5B5332A950C4647202ACCE2865CA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 0/2] sql: ignore \0 in string passed to user function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 30 мар 14:21, Mergen Imeev via Tarantool-patches wrote: > Currently, string passed to user-defined function from SQL can be cropped in > case it contains '\0'. This patch-set fixes this behaviour. > > https://github.com/tarantool/tarantool/issues/5938 > https://github.com/tarantool/tarantool/tree/imeevma/gh-5938-wrong-string-length > > Mergen Imeev (2): > sql: ignore \0 in string passed to C-function > sql: ignore \0 in string passed to Lua-function > > src/box/sql/func.c | 6 ++- > test/CMakeLists.txt | 1 + > test/sql-tap/CMakeLists.txt | 2 + > test/sql-tap/gh-5938-wrong-string-length.c | 42 +++++++++++++++++ > .../gh-5938-wrong-string-length.test.lua | 45 +++++++++++++++++++ > 5 files changed, 94 insertions(+), 2 deletions(-) > create mode 100644 test/sql-tap/CMakeLists.txt > create mode 100644 test/sql-tap/gh-5938-wrong-string-length.c > create mode 100755 test/sql-tap/gh-5938-wrong-string-length.test.lua LGTM. I've checked your patchset into 2.6, 2.7 and master. -- Regards, Kirill Yukhin