From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 2/2] sql: ignore \0 in string passed to Lua-function
Date: Thu, 1 Apr 2021 21:51:06 +0200 [thread overview]
Message-ID: <1da9dba4-2c42-d827-3f61-c30910ff7a1b@tarantool.org> (raw)
In-Reply-To: <20210401084102.GA54278@tarantool.org>
Hi! Thanks for the fixes!
> diff --git "a/changelogs/unreleased/fix-crop-strings-by-\\0-in-user-functions.md" "b/changelogs/unreleased/fix-crop-strings-by-\\0-in-user-functions.md"
> new file mode 100644
> index 000000000..a0aa8a425
> --- /dev/null
> +++ "b/changelogs/unreleased/fix-crop-strings-by-\\0-in-user-functions.md"
> @@ -0,0 +1,4 @@
> +## bugfix/sql
> +
> +* Fixed cropping of a string if it contains '\0' when passing a string
> + to user-defined Lua or C functions.
In the changelog records we use imperative, like in commit titles (because it
seems to be a commonly used way of writing them). Also you need to add the
issue reference to the text in a form `(gh-####)`. Look at the other changelog
files for examples.
next prev parent reply other threads:[~2021-04-01 19:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 11:21 [Tarantool-patches] [PATCH v1 0/2] sql: ignore \0 in string passed to user function Mergen Imeev via Tarantool-patches
2021-03-30 11:21 ` [Tarantool-patches] [PATCH v1 1/2] sql: ignore \0 in string passed to C-function Mergen Imeev via Tarantool-patches
2021-03-31 20:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-01 8:32 ` Mergen Imeev via Tarantool-patches
2021-03-30 11:21 ` [Tarantool-patches] [PATCH v1 2/2] sql: ignore \0 in string passed to Lua-function Mergen Imeev via Tarantool-patches
2021-03-31 20:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-01 8:41 ` Mergen Imeev via Tarantool-patches
2021-04-01 12:01 ` Mergen Imeev via Tarantool-patches
2021-04-01 19:51 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-04-01 22:50 ` Mergen Imeev via Tarantool-patches
2021-04-01 23:09 ` [Tarantool-patches] [PATCH v1 0/2] sql: ignore \0 in string passed to user function Vladislav Shpilevoy via Tarantool-patches
2021-04-02 7:55 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1da9dba4-2c42-d827-3f61-c30910ff7a1b@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 2/2] sql: ignore \0 in string passed to Lua-function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox