From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B30B26EC60; Thu, 1 Apr 2021 22:51:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B30B26EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617306669; bh=0AS/2xqLpaEJC7qbu+7FVctmhblkc2bT0GBhU86RpgY=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=HwUDYkdpK6JxMH25fvhdtQJHyqTY5fwF6R09l6CU7nQA41XO+CM09WmNdim++KLPx iqdkLSQX6jUcISnAaVwltuRP+DUDjWWrxUwWP/jCF6BcRLS/06xnodmIIuvox4Vgcj JgQJZkFypieZ3TRWzH4b4+jIPx56jIEuszmKEoYY= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 018546EC60 for ; Thu, 1 Apr 2021 22:51:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 018546EC60 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1lS3LP-000375-A8; Thu, 01 Apr 2021 22:51:07 +0300 To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org References: <446a9874ec7289914571b7989a194939747d46a7.1617101707.git.imeevma@gmail.com> <20210401084102.GA54278@tarantool.org> Message-ID: <1da9dba4-2c42-d827-3f61-c30910ff7a1b@tarantool.org> Date: Thu, 1 Apr 2021 21:51:06 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210401084102.GA54278@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040321FB41523B8C4F3DDCDACAD7A16B691BFA888FADC425FD4B8F6ABBE37E20B09 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922E451CE6E839B1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637911538129B0A8D078638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CFC965FC73B1F55E04DDCAEEA2B8D391D6A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE709B92020B71E24959FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3C72A182EC22DCD89117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFBE49168A74F91971BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B60417BEADF48D14603AA81AA40904B5D9DBF02ECDB25306B2201CA6A4E26CD07C3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F43AACC0BCEB2632C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824AC8B6CDF511875BC4E8F7B195E1C978315CCB46272B337AC6AAFB493F2837AFDE X-C1DE0DAB: 0D63561A33F958A5FA4BBAFB585FFAC0A088EB9C9B23C4BF8FB5DFCF771778CDD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34411AA3F52B5778B6ADB2D654DA2F215EBFB2BD5D8D361FB6538AA3782C89E26BDCB67DA85D22F9161D7E09C32AA3244CF65181104EEA3EBF152949D1511AC1FC3C6EB905E3A8056B729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf335vdV41UsIXSw== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110B8B8794083CEE3CC7CD476E062C6FE17350177DC4CCD2F8007784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 2/2] sql: ignore \0 in string passed to Lua-function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the fixes! > diff --git "a/changelogs/unreleased/fix-crop-strings-by-\\0-in-user-functions.md" "b/changelogs/unreleased/fix-crop-strings-by-\\0-in-user-functions.md" > new file mode 100644 > index 000000000..a0aa8a425 > --- /dev/null > +++ "b/changelogs/unreleased/fix-crop-strings-by-\\0-in-user-functions.md" > @@ -0,0 +1,4 @@ > +## bugfix/sql > + > +* Fixed cropping of a string if it contains '\0' when passing a string > + to user-defined Lua or C functions. In the changelog records we use imperative, like in commit titles (because it seems to be a commonly used way of writing them). Also you need to add the issue reference to the text in a form `(gh-####)`. Look at the other changelog files for examples.