From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v4 0/3] qsync: evaluate replication_synchro_quorum dynamically Date: Mon, 14 Dec 2020 14:39:32 +0300 [thread overview] Message-ID: <20201214113935.1040421-1-gorcunov@gmail.com> (raw) Guys, take a look please once time permit. v2 (by Serge): - keep replication_synchro_quorum been skipped at bootstrap in load_cfg.lua - eliminate redundant say_info calls - call quorum update routine from replica_set_id/replica_clear_id - use replicaset.registered_count directly when evaluating the formula - make quorum evaluation procedure always return value in allowed range, the only error which may happen here is some syntax error or Lua evaluation errors - a test has been added v3 (by Serge, Mons, Vlad): - use replica.lua in tests - use N symbol in formula - use lua_pcall when evaluating a formula - make formula more safe itself, provide various math helpers - use box_update_replication_synchro_quorum name as a general updater from replication code - do not forget to update raft election quorum inside box_update_replication_synchro_quorum - print warns inside functions evaluator if value get out of bounds v4 (by Vlad): - when testing a formula we walk over all amount of replicas, thus we are sure that later when real evaluation takes place we won't get quorum out of bounds - improve test to make sure that when no quorum aquired the transaction doesn't pass issue https://github.com/tarantool/tarantool/issues/5446 branch gorcunov/gh-5446-eval-quorum-4 Cyrill Gorcunov (3): cfg: add cfg_isnumber helper cfg: support symbolic evaluation of replication_synchro_quorum test: add replication/gh-5446-qsync-eval-quorum.test.lua src/box/box.cc | 147 +++++++++- src/box/box.h | 1 + src/box/lua/load_cfg.lua | 2 +- src/box/replication.cc | 4 +- src/cfg.c | 9 + src/cfg.h | 6 + .../gh-5446-qsync-eval-quorum.result | 268 ++++++++++++++++++ .../gh-5446-qsync-eval-quorum.test.lua | 107 +++++++ test/replication/replica-quorum-1.lua | 1 + test/replication/replica-quorum-2.lua | 1 + test/replication/replica-quorum-3.lua | 1 + test/replication/replica-quorum-4.lua | 1 + test/replication/replica-quorum-5.lua | 1 + test/replication/replica-quorum-6.lua | 1 + 14 files changed, 543 insertions(+), 7 deletions(-) create mode 100644 test/replication/gh-5446-qsync-eval-quorum.result create mode 100644 test/replication/gh-5446-qsync-eval-quorum.test.lua create mode 120000 test/replication/replica-quorum-1.lua create mode 120000 test/replication/replica-quorum-2.lua create mode 120000 test/replication/replica-quorum-3.lua create mode 120000 test/replication/replica-quorum-4.lua create mode 120000 test/replication/replica-quorum-5.lua create mode 120000 test/replication/replica-quorum-6.lua base-commit: 28f3b2f1e845aff49048d92f9062a4dfa365bf57 -- 2.26.2
next reply other threads:[~2020-12-14 11:39 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-14 11:39 Cyrill Gorcunov [this message] 2020-12-14 11:39 ` [Tarantool-patches] [PATCH v4 1/3] cfg: add cfg_isnumber helper Cyrill Gorcunov 2020-12-14 11:39 ` [Tarantool-patches] [PATCH v4 2/3] cfg: support symbolic evaluation of replication_synchro_quorum Cyrill Gorcunov 2020-12-16 13:21 ` Serge Petrenko 2020-12-16 13:35 ` Cyrill Gorcunov 2020-12-17 23:17 ` Vladislav Shpilevoy 2020-12-18 7:25 ` Cyrill Gorcunov 2020-12-20 17:01 ` Vladislav Shpilevoy 2020-12-20 18:28 ` Cyrill Gorcunov 2020-12-21 17:48 ` Vladislav Shpilevoy 2020-12-21 17:49 ` Vladislav Shpilevoy 2020-12-21 20:02 ` Cyrill Gorcunov 2020-12-21 20:12 ` Cyrill Gorcunov 2020-12-14 11:39 ` [Tarantool-patches] [PATCH v4 3/3] test: add replication/gh-5446-qsync-eval-quorum.test.lua Cyrill Gorcunov 2020-12-16 13:25 ` Serge Petrenko 2020-12-17 23:18 ` Vladislav Shpilevoy 2020-12-18 8:14 ` Cyrill Gorcunov 2020-12-20 17:01 ` Vladislav Shpilevoy 2020-12-20 18:27 ` Cyrill Gorcunov 2020-12-21 16:05 ` Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201214113935.1040421-1-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.perepelitsa@corp.mail.ru \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v4 0/3] qsync: evaluate replication_synchro_quorum dynamically' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox