From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B08BE45C304 for ; Mon, 14 Dec 2020 14:39:40 +0300 (MSK) Received: by mail-lf1-f49.google.com with SMTP id a9so29358831lfh.2 for ; Mon, 14 Dec 2020 03:39:40 -0800 (PST) From: Cyrill Gorcunov Date: Mon, 14 Dec 2020 14:39:32 +0300 Message-Id: <20201214113935.1040421-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v4 0/3] qsync: evaluate replication_synchro_quorum dynamically List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml Cc: Mons Anderson , Vladislav Shpilevoy Guys, take a look please once time permit. v2 (by Serge): - keep replication_synchro_quorum been skipped at bootstrap in load_cfg.lua - eliminate redundant say_info calls - call quorum update routine from replica_set_id/replica_clear_id - use replicaset.registered_count directly when evaluating the formula - make quorum evaluation procedure always return value in allowed range, the only error which may happen here is some syntax error or Lua evaluation errors - a test has been added v3 (by Serge, Mons, Vlad): - use replica.lua in tests - use N symbol in formula - use lua_pcall when evaluating a formula - make formula more safe itself, provide various math helpers - use box_update_replication_synchro_quorum name as a general updater from replication code - do not forget to update raft election quorum inside box_update_replication_synchro_quorum - print warns inside functions evaluator if value get out of bounds v4 (by Vlad): - when testing a formula we walk over all amount of replicas, thus we are sure that later when real evaluation takes place we won't get quorum out of bounds - improve test to make sure that when no quorum aquired the transaction doesn't pass issue https://github.com/tarantool/tarantool/issues/5446 branch gorcunov/gh-5446-eval-quorum-4 Cyrill Gorcunov (3): cfg: add cfg_isnumber helper cfg: support symbolic evaluation of replication_synchro_quorum test: add replication/gh-5446-qsync-eval-quorum.test.lua src/box/box.cc | 147 +++++++++- src/box/box.h | 1 + src/box/lua/load_cfg.lua | 2 +- src/box/replication.cc | 4 +- src/cfg.c | 9 + src/cfg.h | 6 + .../gh-5446-qsync-eval-quorum.result | 268 ++++++++++++++++++ .../gh-5446-qsync-eval-quorum.test.lua | 107 +++++++ test/replication/replica-quorum-1.lua | 1 + test/replication/replica-quorum-2.lua | 1 + test/replication/replica-quorum-3.lua | 1 + test/replication/replica-quorum-4.lua | 1 + test/replication/replica-quorum-5.lua | 1 + test/replication/replica-quorum-6.lua | 1 + 14 files changed, 543 insertions(+), 7 deletions(-) create mode 100644 test/replication/gh-5446-qsync-eval-quorum.result create mode 100644 test/replication/gh-5446-qsync-eval-quorum.test.lua create mode 120000 test/replication/replica-quorum-1.lua create mode 120000 test/replication/replica-quorum-2.lua create mode 120000 test/replication/replica-quorum-3.lua create mode 120000 test/replication/replica-quorum-4.lua create mode 120000 test/replication/replica-quorum-5.lua create mode 120000 test/replication/replica-quorum-6.lua base-commit: 28f3b2f1e845aff49048d92f9062a4dfa365bf57 -- 2.26.2