Re: [Tarantool-patches] [PATCH v1 1/1] temporary: locate missing diag in VDBE

[Mergen Imeev <imeevma@tarantool.org>]

Hi! This patch was used to find what is wrong in issue #5537. The new field
were used to save information about the last executed opcode in coredump.
I do not plan to include these changes in master or any other release branch.

On Tue, Dec 01, 2020 at 01:40:58PM +0000, Kirill Yukhin wrote:
> Hello,
> 
> What does temporary mean? Do you intend to see the patch in 2.x?
> 
> On 27 Nov 14:08, Mergen Imeev via Tarantool-patches wrote:
> > ---
> >  src/box/sql/vdbe.c    | 7 +++++++
> >  src/box/sql/vdbeInt.h | 1 +
> >  2 files changed, 8 insertions(+)
> > 
> > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
> > index 724bc188b..0c24a7bce 100644
> > --- a/src/box/sql/vdbe.c
> > +++ b/src/box/sql/vdbe.c
> > @@ -862,6 +862,7 @@ int sqlVdbeExec(Vdbe *p)
> >  	}
> >  #endif
> >  	for(pOp=&aOp[p->pc]; 1; pOp++) {
> > +		p->pOp = pOp;
> 
> I see declaration and set of new field. But I don't see use...
> 
> --
> Regards, Kirill Yukhin