From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5852745C304 for ; Tue, 1 Dec 2020 17:01:40 +0300 (MSK) Date: Tue, 1 Dec 2020 17:01:37 +0300 From: Mergen Imeev Message-ID: <20201201140137.GA7650@tarantool.org> References: <02c5e808b917dae58d18f471f526fb1aa36ebcf5.1606475303.git.imeevma@gmail.com> <20201201134057.hpfe5hyoctempww4@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201201134057.hpfe5hyoctempww4@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1 1/1] temporary: locate missing diag in VDBE List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org Hi! This patch was used to find what is wrong in issue #5537. The new field were used to save information about the last executed opcode in coredump. I do not plan to include these changes in master or any other release branch. On Tue, Dec 01, 2020 at 01:40:58PM +0000, Kirill Yukhin wrote: > Hello, > > What does temporary mean? Do you intend to see the patch in 2.x? > > On 27 Nov 14:08, Mergen Imeev via Tarantool-patches wrote: > > --- > > src/box/sql/vdbe.c | 7 +++++++ > > src/box/sql/vdbeInt.h | 1 + > > 2 files changed, 8 insertions(+) > > > > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > > index 724bc188b..0c24a7bce 100644 > > --- a/src/box/sql/vdbe.c > > +++ b/src/box/sql/vdbe.c > > @@ -862,6 +862,7 @@ int sqlVdbeExec(Vdbe *p) > > } > > #endif > > for(pOp=&aOp[p->pc]; 1; pOp++) { > > + p->pOp = pOp; > > I see declaration and set of new field. But I don't see use... > > -- > Regards, Kirill Yukhin