From: Kirill Yukhin <kyukhin@tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] temporary: locate missing diag in VDBE
Date: Tue, 1 Dec 2020 13:40:58 +0000 [thread overview]
Message-ID: <20201201134057.hpfe5hyoctempww4@tarantool.org> (raw)
In-Reply-To: <02c5e808b917dae58d18f471f526fb1aa36ebcf5.1606475303.git.imeevma@gmail.com>
Hello,
What does temporary mean? Do you intend to see the patch in 2.x?
On 27 Nov 14:08, Mergen Imeev via Tarantool-patches wrote:
> ---
> src/box/sql/vdbe.c | 7 +++++++
> src/box/sql/vdbeInt.h | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
> index 724bc188b..0c24a7bce 100644
> --- a/src/box/sql/vdbe.c
> +++ b/src/box/sql/vdbe.c
> @@ -862,6 +862,7 @@ int sqlVdbeExec(Vdbe *p)
> }
> #endif
> for(pOp=&aOp[p->pc]; 1; pOp++) {
> + p->pOp = pOp;
I see declaration and set of new field. But I don't see use...
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-12-01 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 11:08 imeevma
2020-12-01 13:40 ` Kirill Yukhin [this message]
2020-12-01 14:01 ` Mergen Imeev
-- strict thread matches above, loose matches on Subject: below --
2020-11-27 10:44 imeevma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201134057.hpfe5hyoctempww4@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/1] temporary: locate missing diag in VDBE' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox