From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8097D45C304
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  1 Dec 2020 16:41:02 +0300 (MSK)
Date: Tue, 1 Dec 2020 13:40:58 +0000
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201201134057.hpfe5hyoctempww4@tarantool.org>
References: <02c5e808b917dae58d18f471f526fb1aa36ebcf5.1606475303.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <02c5e808b917dae58d18f471f526fb1aa36ebcf5.1606475303.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] temporary: locate missing
 diag in VDBE
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hello,

What does temporary mean? Do you intend to see the patch in 2.x?

On 27 Nov 14:08, Mergen Imeev via Tarantool-patches wrote:
> ---
>  src/box/sql/vdbe.c    | 7 +++++++
>  src/box/sql/vdbeInt.h | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
> index 724bc188b..0c24a7bce 100644
> --- a/src/box/sql/vdbe.c
> +++ b/src/box/sql/vdbe.c
> @@ -862,6 +862,7 @@ int sqlVdbeExec(Vdbe *p)
>  	}
>  #endif
>  	for(pOp=&aOp[p->pc]; 1; pOp++) {
> +		p->pOp = pOp;

I see declaration and set of new field. But I don't see use...

--
Regards, Kirill Yukhin