Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: forbid data changes in read-only mode
Date: Sun, 22 Nov 2020 14:55:16 +0000	[thread overview]
Message-ID: <20201122145516.GA13704@tarantool.org> (raw)
In-Reply-To: <20201120134737.GA492604@tarantool.org>

On 20 Nov 16:47, Mergen Imeev wrote:
> Hi! Thank you for the fixes. I have one unimportant comment: next time please
> include link to branch
> https://github.com/tarantool/tarantool/tree/sergos/gh-5231-box-execute-writes-in-ro
> instead of link to compare
> https://github.com/tarantool/tarantool/compare/sergos/gh-5231-box-execute-writes-in-ro
> 
> LGTM.

Pushed to master, 2.6 and 2.5. Changelogs are updated correspondingly.
Branch is dropped. 
 

      reply	other threads:[~2020-11-22 14:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 11:29 sergos
2020-11-13 14:01 ` Nikita Pettik
2020-11-16 10:31 ` Mergen Imeev
2020-11-16 20:36   ` Sergey Ostanevich
2020-11-16 21:09     ` Nikita Pettik
2020-11-19  7:41       ` Sergey Ostanevich
2020-11-20 13:47         ` Mergen Imeev
2020-11-22 14:55           ` Nikita Pettik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201122145516.GA13704@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] sql: forbid data changes in read-only mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox