From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9213C469710 for ; Sun, 22 Nov 2020 17:55:17 +0300 (MSK) Date: Sun, 22 Nov 2020 14:55:16 +0000 From: Nikita Pettik Message-ID: <20201122145516.GA13704@tarantool.org> References: <20201110112913.28083-1-sergos@tarantool.org> <20201116103129.GA324907@tarantool.org> <05C5398B-E522-4855-AA34-FB9B41606098@tarantool.org> <20201116210931.GB13996@tarantool.org> <0174562A-F615-4DA8-B265-2124388131AE@tarantool.org> <20201120134737.GA492604@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201120134737.GA492604@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] sql: forbid data changes in read-only mode List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org On 20 Nov 16:47, Mergen Imeev wrote: > Hi! Thank you for the fixes. I have one unimportant comment: next time please > include link to branch > https://github.com/tarantool/tarantool/tree/sergos/gh-5231-box-execute-writes-in-ro > instead of link to compare > https://github.com/tarantool/tarantool/compare/sergos/gh-5231-box-execute-writes-in-ro > > LGTM. Pushed to master, 2.6 and 2.5. Changelogs are updated correspondingly. Branch is dropped.