Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: forbid data changes in read-only mode
Date: Mon, 16 Nov 2020 21:09:31 +0000	[thread overview]
Message-ID: <20201116210931.GB13996@tarantool.org> (raw)
In-Reply-To: <05C5398B-E522-4855-AA34-FB9B41606098@tarantool.org>

On 16 Nov 23:36, Sergey Ostanevich wrote:
> diff --git a/test/sql-tap/gh-5231-box-execute-writes-in-ro.test.lua b/test/sql-tap/gh-5231-box-execute-writes-in-ro.test.lua
> new file mode 100755
> index 000000000..6d95adc2e
> --- /dev/null
> +++ b/test/sql-tap/gh-5231-box-execute-writes-in-ro.test.lua
> @@ -0,0 +1,105 @@
> +#!/usr/bin/env tarantool
> +
> +test = require("sqltester")
> +test:plan(9)
> +
> +local expected_err = "Can't modify data because this instance is in read-only mode."
> +
> +test:execsql([[
> +    CREATE TABLE TEST (A INT, B INT, PRIMARY KEY (A));
> +    INSERT INTO TEST (A, B) VALUES (3, 3);
> +]])
> +
> +box.cfg{read_only = true}
> +
> +test:do_catchsql_test(
> +    "sql-errors-1.1",
> +    [[
> +        INSERT INTO TEST (A, B) VALUES (1, 1);
> +    ]], {
> +        -- <sql-errors-1.1>

These comments are artifacts from porting SQLite test suite with
auto-tools, they are not really needed in new tests :)

  reply	other threads:[~2020-11-16 21:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 11:29 sergos
2020-11-13 14:01 ` Nikita Pettik
2020-11-16 10:31 ` Mergen Imeev
2020-11-16 20:36   ` Sergey Ostanevich
2020-11-16 21:09     ` Nikita Pettik [this message]
2020-11-19  7:41       ` Sergey Ostanevich
2020-11-20 13:47         ` Mergen Imeev
2020-11-22 14:55           ` Nikita Pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116210931.GB13996@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=sergos@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] sql: forbid data changes in read-only mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox