* [Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing
@ 2020-10-13 21:21 Alexander V. Tikhonov
2020-10-15 15:45 ` Igor Munkin
2020-10-16 8:25 ` Kirill Yukhin
0 siblings, 2 replies; 3+ messages in thread
From: Alexander V. Tikhonov @ 2020-10-13 21:21 UTC (permalink / raw)
To: Kirill Yukhin, Igor Munkin; +Cc: tarantool-patches
Restored OSX 13 testing to pass homebrew commit criteria.
Added MACOSX_DEPLOYMENT_TARGET=10.13 environment.
Closes #5374
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/mac-13
Issue: https://github.com/tarantool/tarantool/issues/5374
.gitlab-ci.yml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 7a75edb5e..a346bdb3f 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -213,6 +213,13 @@ release_asan_clang8:
script:
- ${GITLAB_MAKE} test_asan_debian_no_deps
+osx_13_release:
+ tags:
+ - osx_13
+ variables:
+ MACOSX_DEPLOYMENT_TARGET: '10.13'
+ <<: *osx_definition
+
osx_14_release:
tags:
- osx_14
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing
2020-10-13 21:21 [Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing Alexander V. Tikhonov
@ 2020-10-15 15:45 ` Igor Munkin
2020-10-16 8:25 ` Kirill Yukhin
1 sibling, 0 replies; 3+ messages in thread
From: Igor Munkin @ 2020-10-15 15:45 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: tarantool-patches
Sasha,
Thanks for the patch! The changes are LGTM, except a single nit.
On 14.10.20, Alexander V. Tikhonov wrote:
> Restored OSX 13 testing to pass homebrew commit criteria.
> Added MACOSX_DEPLOYMENT_TARGET=10.13 environment.
Typo: s/environment/environment variable/.
Side note: it would be nice to describe the issue fixed by this variable
right in commit message, but I see the related info in the mentioned
ticket, so feel free to ignore.
>
> Closes #5374
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/mac-13
> Issue: https://github.com/tarantool/tarantool/issues/5374
>
> .gitlab-ci.yml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
<snipped>
> --
> 2.25.1
>
--
Best regards,
IM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing
2020-10-13 21:21 [Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing Alexander V. Tikhonov
2020-10-15 15:45 ` Igor Munkin
@ 2020-10-16 8:25 ` Kirill Yukhin
1 sibling, 0 replies; 3+ messages in thread
From: Kirill Yukhin @ 2020-10-16 8:25 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: tarantool-patches
Hello,
On 14 окт 00:21, Alexander V. Tikhonov wrote:
> Restored OSX 13 testing to pass homebrew commit criteria.
> Added MACOSX_DEPLOYMENT_TARGET=10.13 environment.
>
> Closes #5374
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/mac-13
> Issue: https://github.com/tarantool/tarantool/issues/5374
I've checked your patch into 2.4, 2.5 and master.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-16 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-13 21:21 [Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing Alexander V. Tikhonov
2020-10-15 15:45 ` Igor Munkin
2020-10-16 8:25 ` Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox