From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A0430469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 18:56:03 +0300 (MSK)
Date: Thu, 15 Oct 2020 18:45:25 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201015154525.GF32659@tarantool.org>
References: <09afd52172ef5282b97f18ce62b07646d6690681.1602623910.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <09afd52172ef5282b97f18ce62b07646d6690681.1602623910.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add OSX 13 to testing
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

Thanks for the patch! The changes are LGTM, except a single nit.

On 14.10.20, Alexander V. Tikhonov wrote:
> Restored OSX 13 testing to pass homebrew commit criteria.
> Added MACOSX_DEPLOYMENT_TARGET=10.13 environment.

Typo: s/environment/environment variable/.

Side note: it would be nice to describe the issue fixed by this variable
right in commit message, but I see the related info in the mentioned
ticket, so feel free to ignore.

> 
> Closes #5374
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/mac-13
> Issue: https://github.com/tarantool/tarantool/issues/5374
> 
>  .gitlab-ci.yml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

<snipped>

> -- 
> 2.25.1
> 

-- 
Best regards,
IM