From: Kirill Yukhin <kyukhin@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v5] build: introduce LUAJIT_ENABLE_PAIRSMM flag
Date: Wed, 19 Feb 2020 10:49:50 +0300 [thread overview]
Message-ID: <20200219074950.ywt4ikvhahvcc5e3@tarantool.org> (raw)
In-Reply-To: <20191126144837.78132-1-arkholga@tarantool.org>
Hello,
On 26 ноя 17:48, Olga Arkhangelskaia wrote:
> Adds LUAJIT_ENABLE_PAIRSMM flag as a build option for luajit.
> If the flag is set, pairs/ipairs metamethods are available in Lua 5.1.
> For tarantool this option is enabled by default.
>
> Part of #4560
> Branch:https://github.com/tarantool/luajit/tree/OKriw/gh-4560-Enable-LUAJIT_ENABLE_LUA52COMPAT-when-bulding-luajit
>
> v1: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012466.html
> v2: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012489.html
> v3: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012527.html
This change breaks compatibility w/ Lua 5.1
and was checked into 1.10, 2.1, 2.2, 2.3 and master
by mistake.
Right it leads to failures in existing Lua code
(see tarantool/tarantool#4770).
The change was reverted in 1.10, 2.2, 2.3 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-02-19 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 14:48 Olga Arkhangelskaia
2019-11-26 14:55 ` Cyrill Gorcunov
2019-11-26 15:14 ` Igor Munkin
2019-11-26 20:54 ` Konstantin Osipov
2020-02-19 7:49 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219074950.ywt4ikvhahvcc5e3@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5] build: introduce LUAJIT_ENABLE_PAIRSMM flag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox