[Tarantool-patches] [PATCH] Update decNumber library

[Tarantool-patches] [PATCH] Update decNumber library

[Serge Petrenko]

Update decNumber library to silence the build warning produced on too
long integer constant.
---
No issue.
https://github.com/tarantool/tarantool/tree/sp/silence-decnumber-warning-full-ci

 third_party/decNumber | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/third_party/decNumber b/third_party/decNumber
index ec9e5be5a..4f318a5d5 160000
--- a/third_party/decNumber
+++ b/third_party/decNumber
@@ -1 +1 @@
-Subproject commit ec9e5be5a888c9a3de149fa94a2853476f720a88
+Subproject commit 4f318a5d5a1fce1f16f2d6a4e23aa5661647c779
-- 
2.21.0 (Apple Git-122)

Re: [Tarantool-patches] [PATCH] Update decNumber library

[Alexander Turenko]

LGTM.

It also interesting why the warning did not cause fail of the build. We
set -Werror for a Debug build, so I would expect fail. It seems we don't
pass the flag due to some reason. It would be good to look why (I don't
insist, however).

CCed Kirill.

Kirill, please, push it to master, 2.3 and 2.2, but before that push
2125b626faa79fa6c1ca4d770d8088dd2b8d0803 (the previous update of
decNumber submodule, which fixes build in some Mac OS environments) to
2.2. I asked for this in [1]. This will allow to cherry-pick this commit
cleanly downward.

[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-January/013759.html

WBR, Alexander Turenko.

On Fri, Jan 17, 2020 at 04:40:36PM +0300, Serge Petrenko wrote:
> Update decNumber library to silence the build warning produced on too
> long integer constant.
> ---
> No issue.
> https://github.com/tarantool/tarantool/tree/sp/silence-decnumber-warning-full-ci
> 
>  third_party/decNumber | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/third_party/decNumber b/third_party/decNumber
> index ec9e5be5a..4f318a5d5 160000
> --- a/third_party/decNumber
> +++ b/third_party/decNumber
> @@ -1 +1 @@
> -Subproject commit ec9e5be5a888c9a3de149fa94a2853476f720a88
> +Subproject commit 4f318a5d5a1fce1f16f2d6a4e23aa5661647c779
> -- 
> 2.21.0 (Apple Git-122)
> 

Re: [Tarantool-patches] [PATCH] Update decNumber library

[Kirill Yukhin]

Hello,

On 17 янв 16:40, Serge Petrenko wrote:
> Update decNumber library to silence the build warning produced on too
> long integer constant.
> ---
> No issue.
> https://github.com/tarantool/tarantool/tree/sp/silence-decnumber-warning-full-ci

Checked into 2.2, 2.3 and master. Also mentioned commit was cherry-picked into 2.2.

--
Regards, Kirill Yukhin