[Tarantool-patches] [PATCH decNumber 1/1] Fix build on Mac with gcc and XCode 11

[Alexander Turenko]

On Tue, Dec 10, 2019 at 05:13:05PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 01 дек 22:01, Vladislav Shpilevoy wrote:
> > There is a bug in XCode 11 which makes some standard C headers
> > not self sufficient. At least <stdlib.h> and <algorithm> are
> > affected. When they are included first, compilation fails with
> > creepy errors like this:
> > 
> >     In file included
> >     from /Applications/Xcode.app/Contents/Developer/
> >         Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> >         sys/wait.h:110,
> >     from /Applications/Xcode.app/Contents/Developer/
> >         Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> >         stdlib.h:66,
> >     from /Users/gerold/Work/Repositories/tarantool/third_party/
> >         zstd/lib/common/zstd_common.c:16:
> >         /Applications/Xcode.app/Content/Developer/
> >         Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> >         sys/resource.h:
> >     In function 'getiopolicy_np': /Applications/Xcode.app/Contents/Developer/
> >         Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> >         sys/resource.h:447:34: error:
> >             expected declaration specifiers before '__OSX_AVAILABLE_STARTING'
> >             447 | int     getiopolicy_np(int, int)
> >             __OSX_AVAILABLE_STARTING(__MAC_10_5, __IPHONE_2_0);
> > 
> > The patch workarounds the bug by changing header include order.
> > Part of https://github.com/tarantool/tarantool/issues/4580
> 
> Checked into master and bumped new version in Tarantool.

Are there a reason to don't push the bugfix to 2.2?

It will prevent clean applying of future updates of the submodule, so I
would prefer to update it everywhere.

WBR, Alexander Turenko.