Re: [Tarantool-patches] [PATCH luajit 2/7] build: fix build with JIT disabled

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]


Hi, Igor!
Thanks for the fixes!
LGTM
--
Best regards,
Maxim Kokryashkin
 
  
>Понедельник, 27 февраля 2023, 12:18 +03:00 от Igor Munkin <imun@tarantool.org>:
> 
>Sergey,
>
>Thanks for your review!
>
>On 13.02.23, Sergey Kaplun wrote:
>> Hi, Igor!
>> Thanks for the patch!
>> LGTM, except a single nit regarding the commit message.
>>
>> On 13.02.23, Igor Munkin wrote:
>> > struct GCtrace is defined only if LJ_HASJIT is set. Hence all spots
>>
>> Typo: s/Hence,/Hence/
>
>Fixed, force-pushed.
>
>>
>> > where GCtrace is used should be also moved under LJ_HASJIT define.
>> >
>> > Relates to tarantool/tarantool#8252
>>
>> Side note: I see "Relates" and "Related" in our commit logs, so I
>> suggest to use "Relates" for future commits.
>
>I always use "Relates" (except maybe some early commits).
>
>>
>> >
>> > Signed-off-by: Igor Munkin < imun@tarantool.org >
>>
>> <snipped>
>>
>> > --
>> > 2.30.2
>> >
>>
>> --
>> Best regards,
>> Sergey Kaplun
>
>--
>Best regards,
>IM
 

[-- Attachment #2: Type: text/html, Size: 1686 bytes --]