Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Igor Munkin" <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches]  [PATCH luajit 1/7] Minor fixes.
Date: Tue, 14 Feb 2023 16:51:50 +0300	[thread overview]
Message-ID: <1676382710.283141133@f712.i.mail.ru> (raw)
In-Reply-To: <1e6b855feff94f39699b44b231be5850c958475d.1676304797.git.imun@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]


Hi, Igor!
Thanks for the patch!
LGTM.
--
Best regards,
Maxim Kokryashkin
 
  
>Понедельник, 13 февраля 2023, 20:03 +03:00 от Igor Munkin <imun@tarantool.org>:
> 
>From: Mike Pall <mike>
>
>(cherry picked from commit 54484e257f24c47d71b8233844e2ec8664db8071)
>
>This is a tiny patch fixing header dependencies for the build with
>-DLUAJIT_DISABLE_JIT=ON and whitespace inconsistency.
>
>Igor Munkin:
>* added the description
>
>Part of tarantool/tarantool#8069
>
>Signed-off-by: Igor Munkin < imun@tarantool.org >
>---
> src/lib_base.c | 2 +-
> src/lj_gc.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/src/lib_base.c b/src/lib_base.c
>index 398c4f65..eb6da054 100644
>--- a/src/lib_base.c
>+++ b/src/lib_base.c
>@@ -505,7 +505,7 @@ LJLIB_CF(print)
>     tv = L->top-1;
>   }
>   shortcut = (tvisfunc(tv) && funcV(tv)->c.ffid == FF_tostring)
>- && !gcrefu(basemt_it(G(L), LJ_TNUMX));
>+ && !gcrefu(basemt_it(G(L), LJ_TNUMX));
>   for (i = 0; i < nargs; i++) {
>     cTValue *o = &L->base[i];
>     const char *str;
>diff --git a/src/lj_gc.c b/src/lj_gc.c
>index 29387a48..c306047a 100644
>--- a/src/lj_gc.c
>+++ b/src/lj_gc.c
>@@ -25,6 +25,7 @@
> #include "lj_cdata.h"
> #endif
> #include "lj_trace.h"
>+#include "lj_dispatch.h"
> #include "lj_vm.h"
> 
> #define GCSTEPSIZE 1024u
>--
>2.30.2
 

[-- Attachment #2: Type: text/html, Size: 2126 bytes --]

  parent reply	other threads:[~2023-02-14 13:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 17:02 [Tarantool-patches] [PATCH luajit 0/7] Adjust tests to be run when JIT is disabled Igor Munkin via Tarantool-patches
2023-02-13 17:02 ` [Tarantool-patches] [PATCH luajit 1/7] Minor fixes Igor Munkin via Tarantool-patches
2023-02-13 18:47   ` Sergey Kaplun via Tarantool-patches
2023-02-14 13:51   ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-02-13 17:02 ` [Tarantool-patches] [PATCH luajit 2/7] build: fix build with JIT disabled Igor Munkin via Tarantool-patches
2023-02-13 18:53   ` Sergey Kaplun via Tarantool-patches
2023-02-27  9:15     ` Igor Munkin via Tarantool-patches
2023-02-28  8:16       ` Maxim Kokryashkin via Tarantool-patches
2023-02-14 13:53   ` Maxim Kokryashkin via Tarantool-patches
2023-02-13 17:02 ` [Tarantool-patches] [PATCH luajit 3/7] test: stop using utils.selfrun in tests Igor Munkin via Tarantool-patches
2023-02-15  8:08   ` Sergey Kaplun via Tarantool-patches
2023-02-27  9:16     ` Igor Munkin via Tarantool-patches
2023-02-27  9:28       ` Sergey Kaplun via Tarantool-patches
2023-02-15 21:43   ` Maxim Kokryashkin via Tarantool-patches
2023-02-27  9:16     ` Igor Munkin via Tarantool-patches
2023-02-28  8:18       ` Maxim Kokryashkin via Tarantool-patches
2023-02-13 17:02 ` [Tarantool-patches] [PATCH luajit 4/7] test: make skipcond helper more convenient Igor Munkin via Tarantool-patches
2023-02-15  8:46   ` Sergey Kaplun via Tarantool-patches
2023-02-27  9:18     ` Igor Munkin via Tarantool-patches
2023-02-27 10:09       ` Sergey Kaplun via Tarantool-patches
2023-02-28  8:27       ` Maxim Kokryashkin via Tarantool-patches
2023-02-15 22:08   ` Maxim Kokryashkin via Tarantool-patches
2023-02-13 17:02 ` [Tarantool-patches] [PATCH luajit 5/7] test: add skipcond for all JIT-related tests Igor Munkin via Tarantool-patches
2023-02-14 13:50   ` Sergey Kaplun via Tarantool-patches
2023-02-15 22:31   ` Maxim Kokryashkin via Tarantool-patches
2023-02-28 19:02     ` Igor Munkin via Tarantool-patches
2023-03-01 19:31       ` Maxim Kokryashkin via Tarantool-patches
2023-02-13 17:02 ` [Tarantool-patches] [PATCH luajit 6/7] test: fix lua-Harness " Igor Munkin via Tarantool-patches
2023-02-14 12:42   ` Sergey Kaplun via Tarantool-patches
2023-02-28 19:01     ` Igor Munkin via Tarantool-patches
2023-02-15 22:35   ` Maxim Kokryashkin via Tarantool-patches
2023-02-28 19:02     ` Igor Munkin via Tarantool-patches
2023-03-01 19:31       ` Maxim Kokryashkin via Tarantool-patches
2023-02-13 17:02 ` [Tarantool-patches] [PATCH luajit 7/7] ci: add nojit flavor for exotic builds Igor Munkin via Tarantool-patches
2023-02-13 19:14   ` Sergey Kaplun via Tarantool-patches
2023-02-15 21:18   ` Maxim Kokryashkin via Tarantool-patches
2023-02-27  9:36 ` [Tarantool-patches] [PATCH luajit 0/7] Adjust tests to be run when JIT is disabled Igor Munkin via Tarantool-patches
2023-02-28 19:05   ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1676382710.283141133@f712.i.mail.ru \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --subject='Re: [Tarantool-patches]  [PATCH luajit 1/7] Minor fixes.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox