Re: [Tarantool-patches] [PATCH luajit 7/7] ci: add nojit flavor for exotic builds

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]


Hi, Igor!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
 
 
> 
>>Since all testing machinery is adjusted for LuaJIT configuration with
>>disabled compiler support, the new flavor for exotic builds is
>>introduced in LuaJIT CI.
>>
>>Part of tarantool/tarantool#8252
>>
>>Signed-off-by: Igor Munkin < imun@tarantool.org >
>>---
>> .github/workflows/exotic-builds-testing.yml | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>>diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
>>index 67ab9cc3..b28673c6 100644
>>--- a/.github/workflows/exotic-builds-testing.yml
>>+++ b/.github/workflows/exotic-builds-testing.yml
>>@@ -36,7 +36,7 @@ jobs:
>>         BUILDTYPE: [Debug, Release]
>>         ARCH: [ARM64, x86_64]
>>         GC64: [ON, OFF]
>>- FLAVOR: [dualnum, checkhook]
>>+ FLAVOR: [dualnum, checkhook, nojit]
>>         include:
>>           - BUILDTYPE: Debug
>>             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
>>@@ -46,6 +46,8 @@ jobs:
>>             FLAVORFLAGS: -DLUAJIT_NUMMODE=2
>>           - FLAVOR: checkhook
>>             FLAVORFLAGS: -DLUAJIT_ENABLE_CHECKHOOK=ON
>>+ - FLAVOR: nojit
>>+ FLAVORFLAGS: -DLUAJIT_DISABLE_JIT=ON
>>         exclude:
>>           # DUALNUM is default for ARM64, no need for additional testing.
>>           - FLAVOR: dualnum
>>--
>>2.30.2
> 

[-- Attachment #2: Type: text/html, Size: 2678 bytes --]