From: Sergey Nikiforov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 1/2] base64: fix decoder output buffer overrun (reads)
Date: Tue, 26 Jan 2021 19:48:48 +0300 [thread overview]
Message-ID: <0fe951d6-5202-96a0-f3ec-e6b4abd1ee55@tarantool.org> (raw)
In-Reply-To: <a015ce9d-5c46-a3f6-0fa0-b776b01d82b3@tarantool.org>
On 26.01.2021 19:37, Sergey Nikiforov wrote:
> On 21.01.2021 5:16, Alexander Turenko wrote:
>> On Mon, Jan 11, 2021 at 12:45:00PM +0300, Sergey Nikiforov wrote:
>>> Was caught by base64 test with enabled ASAN.
>>
>> It seems, we have a problem in CI, otherwise it would be detected. At
>> least, I don't see an explicit suppression relevant to the base64 code
>> or disabling the test under this CI job.
>>
>> Can you, please, investigate, how to enable it in CI, so we'll catch the
>> similar problem next time if it'll appear?
>
> ASAN is not used in CI now. Which is clearly wrong.
> Right now a lot of tests fail if LeakSanitizer is enabled (the default
> for ASAN), but only 1 test (unit/guard.test) fails if LeakSanitizer if
> disabled. So it is quite straightforward:
>
> CC=clang CXX=clang++ cmake . -DENABLE_ASAN=ON && make -j
> ASAN_OPTIONS=detect_leaks=0 test/test-run.py
>
> (test-run.py is launched from several Makefiles)
>
> I propose creating tasks to make unit/guard.test "ASAN-tolerant" (ASAN
> prints warning which causes .result mismatch) and to add ASAN targets to
> CI. Should it be GitLab or GitHub Actions?
>
> We should probably also look on LeakSanitizer issues, some of them are
> probably real bugs and not just tests sloppiness.
ASAN with LeakSanitizer enabled (the default):
Statistics:
* disabled: 127
* fail: 755
* pass: 414
Fixing this is a BIG task.
next prev parent reply other threads:[~2021-01-26 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 9:44 [Tarantool-patches] [PATCH v6 0/2] base64: Fix decoder, improve its performance Sergey Nikiforov via Tarantool-patches
2021-01-11 9:45 ` [Tarantool-patches] [PATCH v6 1/2] base64: fix decoder output buffer overrun (reads) Sergey Nikiforov via Tarantool-patches
2021-01-21 2:16 ` Alexander Turenko via Tarantool-patches
2021-01-26 16:37 ` Sergey Nikiforov via Tarantool-patches
2021-01-26 16:48 ` Sergey Nikiforov via Tarantool-patches [this message]
2021-02-20 11:30 ` Alexander Turenko via Tarantool-patches
2021-02-20 12:49 ` Alexander Turenko via Tarantool-patches
2021-02-25 8:25 ` Sergey Nikiforov via Tarantool-patches
2021-02-27 18:47 ` Alexander Turenko via Tarantool-patches
2021-01-11 9:45 ` [Tarantool-patches] [PATCH v6 2/2] base64: improve decoder performance Sergey Nikiforov via Tarantool-patches
2021-01-21 15:31 ` Alexander Turenko via Tarantool-patches
2021-01-26 16:37 ` Sergey Nikiforov via Tarantool-patches
2021-02-20 12:51 ` Alexander Turenko via Tarantool-patches
2021-01-12 19:39 ` [Tarantool-patches] [PATCH v6 0/2] base64: Fix decoder, improve its performance Alexander Turenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe951d6-5202-96a0-f3ec-e6b4abd1ee55@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=void@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 1/2] base64: fix decoder output buffer overrun (reads)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox