From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 812F47030B; Tue, 26 Jan 2021 19:48:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 812F47030B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611679732; bh=NT+Rc+ISui0EzYlz9BDl++tEO9Tt9xS1kBCFjp+BIkc=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nP7xdM/RAIfjZphGRmBAytXKHpFIcnbUGK3yMa1aL4wBYQcU7CRXS35NrWiWgdAXu s2yowrmX+OQm0N1q2ORa+1nsgd4aM0gAIVdDpw7L0cKR0x5ez+hue0ZuK5jjtfRT+r TNM4iL2IFxm8v3oEj9SGdER8qaCcDjN2G914fQmw= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 383717030B for ; Tue, 26 Jan 2021 19:48:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 383717030B Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l4RWM-00063b-5F; Tue, 26 Jan 2021 19:48:50 +0300 To: Alexander Turenko References: <7f5ce3321cda6d4305282af486ed2f493b920d1f.1610357625.git.void@tarantool.org> <20210121021627.2dzyh7fho2cvjlrz@tkn_work_nb> Message-ID: <0fe951d6-5202-96a0-f3ec-e6b4abd1ee55@tarantool.org> Date: Tue, 26 Jan 2021 19:48:48 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92BC6D7A73B5E1EC9E9902A44F577D7AF667D68DB0D7EAFAB00894C459B0CD1B931B4F5F9782956BDF96D817F8F38AFD62A9F757D15EFBF3B67A9CA496E58B691 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73F300A97FDD4E158EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063737452AF4BFD067BF8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC404929DF707E7A8860F95ED7852199585EDD61E78FB6072E389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92A417C69337E82CC2CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCCD74D44300978AB675ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E735BAAD9279A72BC9ABC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F5D41B9178041F3E72623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A569E0FC5DDA9A1E76D0864305E522EF0EF40B677204C0AE8ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34CA9B3B5DE5D383E60C310F813D66C1555B0BF79258811948DA85B7D574FF7AEE2DE34BB4011CEEF21D7E09C32AA3244CB6E5A430C137C2176C2CD0E4A7866D3835DA7DC5AF9B58C083B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbLwCnVtyrictoIu/UXiXew== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822FDF70B72AA566FCA736B3C7531583C86DD675A873A6B1A573284F99205A65E8EFB559BB5D741EB966AABCD5B59A9F6DF9ABAAAF6BC5F075B67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v6 1/2] base64: fix decoder output buffer overrun (reads) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Nikiforov via Tarantool-patches Reply-To: Sergey Nikiforov Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 26.01.2021 19:37, Sergey Nikiforov wrote: > On 21.01.2021 5:16, Alexander Turenko wrote: >> On Mon, Jan 11, 2021 at 12:45:00PM +0300, Sergey Nikiforov wrote: >>> Was caught by base64 test with enabled ASAN. >> >> It seems, we have a problem in CI, otherwise it would be detected. At >> least, I don't see an explicit suppression relevant to the base64 code >> or disabling the test under this CI job. >> >> Can you, please, investigate, how to enable it in CI, so we'll catch the >> similar problem next time if it'll appear? > > ASAN is not used in CI now. Which is clearly wrong. > Right now a lot of tests fail if LeakSanitizer is enabled (the default > for ASAN), but only 1 test (unit/guard.test) fails if LeakSanitizer if > disabled. So it is quite straightforward: > > CC=clang CXX=clang++ cmake . -DENABLE_ASAN=ON && make -j > ASAN_OPTIONS=detect_leaks=0 test/test-run.py > > (test-run.py is launched from several Makefiles) > > I propose creating tasks to make unit/guard.test "ASAN-tolerant" (ASAN > prints warning which causes .result mismatch) and to add ASAN targets to > CI. Should it be GitLab or GitHub Actions? > > We should probably also look on LeakSanitizer issues, some of them are > probably real bugs and not just tests sloppiness. ASAN with LeakSanitizer enabled (the default): Statistics: * disabled: 127 * fail: 755 * pass: 414 Fixing this is a BIG task.