Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro replication usage reporting

[Serge Petrenko <sergepetrenko@tarantool.org>]

15.10.2020 02:50, Vladislav Shpilevoy пишет:
> Hi! Thanks for the patch!
>
> See 2 comments below.
Thanks for the review!
>
>> diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua
>> index a04995d8a..c1ae5f81b 100755
>> --- a/test/box-tap/feedback_daemon.test.lua
>> +++ b/test/box-tap/feedback_daemon.test.lua
>> @@ -195,11 +197,12 @@ box.space.features_memtx:create_index('functional_multikey',
>>   actual = daemon.generate_feedback()
>>   local schema_stats = actual.features.schema
>>   test:test('features.schema', function(t)
>> -    t:plan(12)
>> -    t:is(schema_stats.memtx_spaces, 2, 'memtx engine usage gathered')
>> +    t:plan(13)
>> +    t:is(schema_stats.memtx_spaces, 3, 'memtx engine usage gathered')
>>       t:is(schema_stats.vinyl_spaces, 1, 'vinyl engine usage gathered')
>>       t:is(schema_stats.temporary_spaces, 1, 'temporary space usage gathered')
>>       t:is(schema_stats.local_spaces, 1, 'local space usage gathered')
>> +    t:is(schema_stats.sync_spaces, 1, 'sync space  usage gathered')
> 1. Double whitespace in 'space  usage'. At least the macbooks >= 2016
> are stylish.
Yep, they look nice. Fixed, thanks!
>>       t:is(schema_stats.tree_indices, 6, 'tree index gathered')
>>       t:is(schema_stats.hash_indices, 1, 'hash index gathered')
>>       t:is(schema_stats.rtree_indices, 1, 'rtree index gathered')
> 2. I also see you pushed a new commit on top of this branch about reporting
> box.on_reload_configuration. But why? It is not even documented anywhere.
> We could just drop this function.
It was Mons's request. He wants to see whether anyone uses this feature 
or not.
If you're against this, let's discuss.

-- 
Serge Petrenko