From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>, kyukhin@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro replication usage reporting
Date: Thu, 15 Oct 2020 21:45:29 +0200 [thread overview]
Message-ID: <042210b4-6186-9f96-277b-e60fed276bc2@tarantool.org> (raw)
In-Reply-To: <0a55a33f-2891-f232-4f93-ef0b5d436ab7@tarantool.org>
>>> t:is(schema_stats.tree_indices, 6, 'tree index gathered')
>>> t:is(schema_stats.hash_indices, 1, 'hash index gathered')
>>> t:is(schema_stats.rtree_indices, 1, 'rtree index gathered')
>> 2. I also see you pushed a new commit on top of this branch about reporting
>> box.on_reload_configuration. But why? It is not even documented anywhere.
>> We could just drop this function.
> It was Mons's request. He wants to see whether anyone uses this feature or not.
> If you're against this, let's discuss.
Ok, leave it then, I don't mind. Still looks strange though. We really
could just drop it. It is not a feature. It is an undocumented piece of
code. Same as box.internal.
next prev parent reply other threads:[~2020-10-15 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 13:34 Serge Petrenko
2020-10-13 13:54 ` Serge Petrenko
2020-10-13 14:01 ` Cyrill Gorcunov
2020-10-13 14:05 ` Serge Petrenko
2020-10-13 15:56 ` Serge Petrenko
2020-10-14 23:50 ` Vladislav Shpilevoy
2020-10-15 8:30 ` Serge Petrenko
2020-10-15 19:45 ` Vladislav Shpilevoy [this message]
2020-10-20 17:09 ` Илья Конюхов
2020-10-20 19:16 ` Serge Petrenko
2020-10-21 8:42 ` Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=042210b4-6186-9f96-277b-e60fed276bc2@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro replication usage reporting' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox