From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CF061469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 22:45:30 +0300 (MSK)
References: <20201013133418.34422-1-sergepetrenko@tarantool.org>
 <53c790b8-188c-d59e-a682-153ad0b51793@tarantool.org>
 <0a55a33f-2891-f232-4f93-ef0b5d436ab7@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <042210b4-6186-9f96-277b-e60fed276bc2@tarantool.org>
Date: Thu, 15 Oct 2020 21:45:29 +0200
MIME-Version: 1.0
In-Reply-To: <0a55a33f-2891-f232-4f93-ef0b5d436ab7@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro
 replication usage reporting
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, kyukhin@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

>>>       t:is(schema_stats.tree_indices, 6, 'tree index gathered')
>>>       t:is(schema_stats.hash_indices, 1, 'hash index gathered')
>>>       t:is(schema_stats.rtree_indices, 1, 'rtree index gathered')
>> 2. I also see you pushed a new commit on top of this branch about reporting
>> box.on_reload_configuration. But why? It is not even documented anywhere.
>> We could just drop this function.
> It was Mons's request. He wants to see whether anyone uses this feature or not.
> If you're against this, let's discuss.

Ok, leave it then, I don't mind. Still looks strange though. We really
could just drop it. It is not a feature. It is an undocumented piece of
code. Same as box.internal.