From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9E661469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 11:30:50 +0300 (MSK)
References: <20201013133418.34422-1-sergepetrenko@tarantool.org>
 <53c790b8-188c-d59e-a682-153ad0b51793@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <0a55a33f-2891-f232-4f93-ef0b5d436ab7@tarantool.org>
Date: Thu, 15 Oct 2020 11:30:49 +0300
MIME-Version: 1.0
In-Reply-To: <53c790b8-188c-d59e-a682-153ad0b51793@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro
 replication usage reporting
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, kyukhin@tarantool.org
Cc: tarantool-patches@dev.tarantool.org


15.10.2020 02:50, Vladislav Shpilevoy пишет:
> Hi! Thanks for the patch!
>
> See 2 comments below.
Thanks for the review!
>
>> diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua
>> index a04995d8a..c1ae5f81b 100755
>> --- a/test/box-tap/feedback_daemon.test.lua
>> +++ b/test/box-tap/feedback_daemon.test.lua
>> @@ -195,11 +197,12 @@ box.space.features_memtx:create_index('functional_multikey',
>>   actual = daemon.generate_feedback()
>>   local schema_stats = actual.features.schema
>>   test:test('features.schema', function(t)
>> -    t:plan(12)
>> -    t:is(schema_stats.memtx_spaces, 2, 'memtx engine usage gathered')
>> +    t:plan(13)
>> +    t:is(schema_stats.memtx_spaces, 3, 'memtx engine usage gathered')
>>       t:is(schema_stats.vinyl_spaces, 1, 'vinyl engine usage gathered')
>>       t:is(schema_stats.temporary_spaces, 1, 'temporary space usage gathered')
>>       t:is(schema_stats.local_spaces, 1, 'local space usage gathered')
>> +    t:is(schema_stats.sync_spaces, 1, 'sync space  usage gathered')
> 1. Double whitespace in 'space  usage'. At least the macbooks >= 2016
> are stylish.
Yep, they look nice. Fixed, thanks!
>>       t:is(schema_stats.tree_indices, 6, 'tree index gathered')
>>       t:is(schema_stats.hash_indices, 1, 'hash index gathered')
>>       t:is(schema_stats.rtree_indices, 1, 'rtree index gathered')
> 2. I also see you pushed a new commit on top of this branch about reporting
> box.on_reload_configuration. But why? It is not even documented anywhere.
> We could just drop this function.
It was Mons's request. He wants to see whether anyone uses this feature 
or not.
If you're against this, let's discuss.

-- 
Serge Petrenko