Tarantool development patches archive
 help / color / mirror / Atom feed
From: Oleg Babin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, imun@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 0/4] fiber: keep reference to userdata if fiber created once
Date: Wed, 8 Sep 2021 15:54:39 +0300	[thread overview]
Message-ID: <0727309a-8656-3cf8-b8aa-2600533ea9af@tarantool.org> (raw)
In-Reply-To: <5a3d0fa1-f7dd-9bb7-b465-e233f225b4af@tarantool.org>


On 08.09.2021 00:43, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch.
>
> So, did you see my comment in the previous version?
> Maybe add an own constant to fiber.h and add a static
> assertion into the main executable?
>
> This would make the code simpler IMHO. The solution
> about yields and Lua GC uses extern function only because
> it actually provides notably better perf.


Thanks for your comment. Yes, I saw. I sent v3 before you wrote it.

I hope I'll find a time to fix it and send v4 soon.


      reply	other threads:[~2021-09-08 12:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 20:49 Oleg Babin via Tarantool-patches
2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 1/4] fiber: rename ref to storage_ref Oleg Babin via Tarantool-patches
2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 2/4] fiber: pass struct fiber into lbox_pushfiber instead of id Oleg Babin via Tarantool-patches
2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 3/4] lua/utils: make LUA_NOREF value public Oleg Babin via Tarantool-patches
2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 4/4] fiber: keep reference to userdata if fiber created once Oleg Babin via Tarantool-patches
2021-09-07 21:43 ` [Tarantool-patches] [PATCH v3 0/4] " Vladislav Shpilevoy via Tarantool-patches
2021-09-08 12:54   ` Oleg Babin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0727309a-8656-3cf8-b8aa-2600533ea9af@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=olegrok@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 0/4] fiber: keep reference to userdata if fiber created once' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox