From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A22926EC55; Wed, 8 Sep 2021 15:54:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A22926EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1631105683; bh=AWj17NacTEotPGb10fOikRUxqf0tBGaYdoc6Lxi3xJM=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=G+swfTK1ai/Ebn/VtE31gNWfIGN9QTFkVeJCLvG6e1x96jqI0xcEiwgmdvnrNaIwu dI4pqda8tNxvw2Jcq3cIrnzu/nR6u3bN24cJU+Mm65qdLSviZdU/JMobUGSdvr/17m ZQU6yIIF6AhE8/Qk5UbIRlCmQtIy4nrjGrP+ZveY= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5EC246EC55 for ; Wed, 8 Sep 2021 15:54:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5EC246EC55 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1mNx68-0007Fd-CQ; Wed, 08 Sep 2021 15:54:40 +0300 To: Vladislav Shpilevoy , imun@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <5a3d0fa1-f7dd-9bb7-b465-e233f225b4af@tarantool.org> Message-ID: <0727309a-8656-3cf8-b8aa-2600533ea9af@tarantool.org> Date: Wed, 8 Sep 2021 15:54:39 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <5a3d0fa1-f7dd-9bb7-b465-e233f225b4af@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91AE02D33A9C88A2F5A5BD9D2085A59586CBBC9313A5A610100894C459B0CD1B9E0CC43565CD7986BBF95D1B06FD93805D9E36ED41A204882A2698D7B1DC6BD28 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AED985C8E545F588EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727599E9BE65898D58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D812CB57B487716DC76D02A8BDD610E478117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C1E1736EDDE8D47906E0066C2D8992A164AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C32772BB1FFAF0144FBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7EE061C4D93700B7A731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5050D845B7B6454ED73CBAE639CBCFD2F74 X-C1DE0DAB: 0D63561A33F958A5F25142F9498708FB56F86D46B79655723213D9601BA94316D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3458239C6F30CE7ACF75B460A5A837A28527D9269C957E8E8C8F617D592DBC0708544BC728ED7641C01D7E09C32AA3244C0D981360A021EF1ED6374C658CC50D123FD9C8CA1B0515E0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojV8xpaxME9p8YvZqr4cC7aQ== X-Mailru-Sender: 583F1D7ACE8F49BD1042885CEC987B6BE84816CA1FE58AB55914851F65FE7C2779D0F6AC9C0BD8DB7019711D9D5B048E1458020726E2BC9FD5ECBA0B92C0A936CDC7563AA7CEBD287402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 0/4] fiber: keep reference to userdata if fiber created once X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 08.09.2021 00:43, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch. > > So, did you see my comment in the previous version? > Maybe add an own constant to fiber.h and add a static > assertion into the main executable? > > This would make the code simpler IMHO. The solution > about yields and Lua GC uses extern function only because > it actually provides notably better perf. Thanks for your comment. Yes, I saw. I sent v3 before you wrote it. I hope I'll find a time to fix it and send v4 soon.