From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: olegrok@tarantool.org, imun@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v3 0/4] fiber: keep reference to userdata if fiber created once Date: Tue, 7 Sep 2021 23:43:24 +0200 [thread overview] Message-ID: <5a3d0fa1-f7dd-9bb7-b465-e233f225b4af@tarantool.org> (raw) In-Reply-To: <cover.1630701714.git.babinoleg@mail.ru> Hi! Thanks for the patch. So, did you see my comment in the previous version? Maybe add an own constant to fiber.h and add a static assertion into the main executable? This would make the code simpler IMHO. The solution about yields and Lua GC uses extern function only because it actually provides notably better perf.
next prev parent reply other threads:[~2021-09-07 21:43 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-03 20:49 Oleg Babin via Tarantool-patches 2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 1/4] fiber: rename ref to storage_ref Oleg Babin via Tarantool-patches 2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 2/4] fiber: pass struct fiber into lbox_pushfiber instead of id Oleg Babin via Tarantool-patches 2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 3/4] lua/utils: make LUA_NOREF value public Oleg Babin via Tarantool-patches 2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 4/4] fiber: keep reference to userdata if fiber created once Oleg Babin via Tarantool-patches 2021-09-07 21:43 ` Vladislav Shpilevoy via Tarantool-patches [this message] 2021-09-08 12:54 ` [Tarantool-patches] [PATCH v3 0/4] " Oleg Babin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5a3d0fa1-f7dd-9bb7-b465-e233f225b4af@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=olegrok@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 0/4] fiber: keep reference to userdata if fiber created once' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox