Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 00/13] Applier rollback reason
Date: Tue, 15 Jun 2021 16:43:09 +0300
Message-ID: <05cb4b69-6c64-6037-5bcf-c0e1911cb76f@tarantool.org> (raw)
In-Reply-To: <cover.1623448465.git.v.shpilevoy@tarantool.org>



12.06.2021 00:56, Vladislav Shpilevoy пишет:
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-6027-rollback-reason
> Issue: https://github.com/tarantool/tarantool/issues/6027

Hi! Good job on the patchset!

LGTM with one small comment for the last commit.

> Vladislav Shpilevoy (13):
>    error: introduce ER_CASCADE_ROLLBACK
>    test: remove replica-applier-rollback.lua
>    journal: make journal_write() set diag on error
>    wal: refactor wal_write_to_disk()
>    diag: introduce diag_set_detailed()
>    wal: encapsulate ER_WAL_IO
>    txn: change limbo rollback check in the trigger
>    journal: introduce proper error codes
>    txn: assert after WAL write that txn is not done
>    txn: install proper diag errors on txn fail
>    wal: introduce JOURNAL_ENTRY_ERR_CASCADE
>    txn: introduce TXN_SIGNATURE_ABORT
>    txn: stop TXN_SIGNATURE_ABORT override
>
>   .../unreleased/gh-6027-applier-lost-error.md  |  7 ++
>   src/box/applier.cc                            | 18 ++--
>   src/box/box.cc                                |  8 +-
>   src/box/errcode.h                             |  3 +-
>   src/box/journal.c                             | 16 ++++
>   src/box/journal.h                             | 30 ++++++-
>   src/box/memtx_engine.c                        |  2 +-
>   src/box/raft.c                                | 10 ++-
>   src/box/txn.c                                 | 87 +++++++++++++------
>   src/box/txn.h                                 | 38 +++++++-
>   src/box/txn_limbo.c                           | 37 ++++----
>   src/box/vy_scheduler.c                        |  2 +-
>   src/box/wal.c                                 | 50 ++++++-----
>   src/lib/core/diag.h                           |  9 +-
>   test/box/errinj.result                        |  2 +-
>   test/box/error.result                         |  3 +-
>   .../gh-4730-applier-rollback.result           |  2 +-
>   .../gh-4730-applier-rollback.test.lua         |  2 +-
>   .../gh-6027-applier-error-show.result         | 82 +++++++++++++++++
>   .../gh-6027-applier-error-show.test.lua       | 31 +++++++
>   test/replication/replica-applier-rollback.lua | 16 ----
>   test/replication/suite.cfg                    |  1 +
>   test/replication/suite.ini                    |  2 +-
>   23 files changed, 348 insertions(+), 110 deletions(-)
>   create mode 100644 changelogs/unreleased/gh-6027-applier-lost-error.md
>   create mode 100644 test/replication/gh-6027-applier-error-show.result
>   create mode 100644 test/replication/gh-6027-applier-error-show.test.lua
>   delete mode 100644 test/replication/replica-applier-rollback.lua
>

-- 
Serge Petrenko


  parent reply	other threads:[~2021-06-15 13:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 21:56 Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 01/13] error: introduce ER_CASCADE_ROLLBACK Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 10/13] txn: install proper diag errors on txn fail Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 11/13] wal: introduce JOURNAL_ENTRY_ERR_CASCADE Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 12/13] txn: introduce TXN_SIGNATURE_ABORT Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 13/13] txn: stop TXN_SIGNATURE_ABORT override Vladislav Shpilevoy via Tarantool-patches
2021-06-15 13:44   ` Serge Petrenko via Tarantool-patches
2021-06-15 19:34     ` Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 02/13] test: remove replica-applier-rollback.lua Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 03/13] journal: make journal_write() set diag on error Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 04/13] wal: refactor wal_write_to_disk() Vladislav Shpilevoy via Tarantool-patches
2021-06-15 20:46   ` Cyrill Gorcunov via Tarantool-patches
2021-06-16  6:22     ` Vladislav Shpilevoy via Tarantool-patches
2021-06-16  8:02       ` Cyrill Gorcunov via Tarantool-patches
2021-06-16 23:32         ` Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 05/13] diag: introduce diag_set_detailed() Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 06/13] wal: encapsulate ER_WAL_IO Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 07/13] txn: change limbo rollback check in the trigger Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 08/13] journal: introduce proper error codes Vladislav Shpilevoy via Tarantool-patches
2021-06-11 21:56 ` [Tarantool-patches] [PATCH 09/13] txn: assert after WAL write that txn is not done Vladislav Shpilevoy via Tarantool-patches
2021-06-15 13:43 ` Serge Petrenko via Tarantool-patches [this message]
2021-06-16 23:32 ` [Tarantool-patches] [PATCH 00/13] Applier rollback reason Vladislav Shpilevoy via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05cb4b69-6c64-6037-5bcf-c0e1911cb76f@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git