From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2C90B6EC55; Tue, 15 Jun 2021 16:43:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2C90B6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623764591; bh=jqikqQxbziGilPeqhjm4CseuglBN3wnN7nQgIFN/ynw=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ItZMUMChUyNnnBdgBycNQVtz1BiggpaaIabtao7kGzo8kuv13Y92+DzF4uqYS3IxE Oyn6pYZ7tQpGHPmQc6q65gjaJPz7Sk6QEtpaYMQkBBv8lr9AVomn3p3+A3bfD2trTo ge6tN82L0yAZwwS1eqdzKsG/IwbEPSP5z7zaQDJY= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 97EA46EC55 for ; Tue, 15 Jun 2021 16:43:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 97EA46EC55 Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1lt9LR-0001ZS-Kl; Tue, 15 Jun 2021 16:43:10 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com References: Message-ID: <05cb4b69-6c64-6037-5bcf-c0e1911cb76f@tarantool.org> Date: Tue, 15 Jun 2021 16:43:09 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C544BBC2A69B1B4100B389BF69B7A224D7C182A05F5380850407AA6E1B3387F83E847C9230D38E1D0BC023354651A14AEDC0D364D197ADC1A70 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72791110C931D1596EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F553454BD40B3B398638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8261F2B0E8DDE961609215CC9826E30BF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4BA7B8E9D6D956BB52D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3457EE4B4996FC546040F9FF01DFDA4A8C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F790063723B0D190C46BCD7DEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831EDCEC9DF77A8B2DBE78E5B5B57A3F822 X-C1DE0DAB: 0D63561A33F958A5040A6FBB09FF2B97F9774A8D11437C39AFE27E192A50B393D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FBC5FED0552DA851410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34806D3522FB05EB39412A1354390BCC7E828E65571F2D0B3B1F5C69C455255286730E25E4C31A63F11D7E09C32AA3244C1306F50E68E66D2049841958CBDB0D86250262A5EE9971B0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj6OL1iHTyIM0som4osDIqAA== X-Mailru-Sender: 583F1D7ACE8F49BD9DF7A8DAE6E2B08ACBBD6334F98F144B2BA7819690D5C0DC1C4622495F56DB38424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 00/13] Applier rollback reason X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 12.06.2021 00:56, Vladislav Shpilevoy пишет: > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-6027-rollback-reason > Issue: https://github.com/tarantool/tarantool/issues/6027 Hi! Good job on the patchset! LGTM with one small comment for the last commit. > Vladislav Shpilevoy (13): > error: introduce ER_CASCADE_ROLLBACK > test: remove replica-applier-rollback.lua > journal: make journal_write() set diag on error > wal: refactor wal_write_to_disk() > diag: introduce diag_set_detailed() > wal: encapsulate ER_WAL_IO > txn: change limbo rollback check in the trigger > journal: introduce proper error codes > txn: assert after WAL write that txn is not done > txn: install proper diag errors on txn fail > wal: introduce JOURNAL_ENTRY_ERR_CASCADE > txn: introduce TXN_SIGNATURE_ABORT > txn: stop TXN_SIGNATURE_ABORT override > > .../unreleased/gh-6027-applier-lost-error.md | 7 ++ > src/box/applier.cc | 18 ++-- > src/box/box.cc | 8 +- > src/box/errcode.h | 3 +- > src/box/journal.c | 16 ++++ > src/box/journal.h | 30 ++++++- > src/box/memtx_engine.c | 2 +- > src/box/raft.c | 10 ++- > src/box/txn.c | 87 +++++++++++++------ > src/box/txn.h | 38 +++++++- > src/box/txn_limbo.c | 37 ++++---- > src/box/vy_scheduler.c | 2 +- > src/box/wal.c | 50 ++++++----- > src/lib/core/diag.h | 9 +- > test/box/errinj.result | 2 +- > test/box/error.result | 3 +- > .../gh-4730-applier-rollback.result | 2 +- > .../gh-4730-applier-rollback.test.lua | 2 +- > .../gh-6027-applier-error-show.result | 82 +++++++++++++++++ > .../gh-6027-applier-error-show.test.lua | 31 +++++++ > test/replication/replica-applier-rollback.lua | 16 ---- > test/replication/suite.cfg | 1 + > test/replication/suite.ini | 2 +- > 23 files changed, 348 insertions(+), 110 deletions(-) > create mode 100644 changelogs/unreleased/gh-6027-applier-lost-error.md > create mode 100644 test/replication/gh-6027-applier-error-show.result > create mode 100644 test/replication/gh-6027-applier-error-show.test.lua > delete mode 100644 test/replication/replica-applier-rollback.lua > -- Serge Petrenko