From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tarantool-patches@dev.tarantool.org, gorcunov@gmail.com, sergepetrenko@tarantool.org Subject: [Tarantool-patches] [PATCH 02/13] test: remove replica-applier-rollback.lua Date: Fri, 11 Jun 2021 23:56:10 +0200 [thread overview] Message-ID: <69c1012338d9e08fca08ea99b6f8d8c13205d289.1623448465.git.v.shpilevoy@tarantool.org> (raw) In-Reply-To: <cover.1623448465.git.v.shpilevoy@tarantool.org> The script name was too long. It was also used as a name for the unix socket file on which the replica listens. As a result, the test couldn't start, at least on my machine. Besides, the script was not any different from the existing replica.lua, except a couple of not important settings. The patch drops it and makes gh-4730-applier-rollback.test.lua use replica.lua. Now it can run on my machine. Done as a preparation for #6027, which is slightly related to the test - it is also about errors in applier and their display. --- test/replication/gh-4730-applier-rollback.result | 2 +- .../gh-4730-applier-rollback.test.lua | 2 +- test/replication/replica-applier-rollback.lua | 16 ---------------- 3 files changed, 2 insertions(+), 18 deletions(-) delete mode 100644 test/replication/replica-applier-rollback.lua diff --git a/test/replication/gh-4730-applier-rollback.result b/test/replication/gh-4730-applier-rollback.result index 26a0eb6fa..bd9530074 100644 --- a/test/replication/gh-4730-applier-rollback.result +++ b/test/replication/gh-4730-applier-rollback.result @@ -19,7 +19,7 @@ box.schema.user.grant('guest', 'replication') -- -- Create replica instance, we're the master and -- start it, no data to sync yet though -test_run:cmd("create server replica_slave with rpl_master=default, script='replication/replica-applier-rollback.lua'") +test_run:cmd("create server replica_slave with rpl_master=default, script='replication/replica.lua'") | --- | - true | ... diff --git a/test/replication/gh-4730-applier-rollback.test.lua b/test/replication/gh-4730-applier-rollback.test.lua index de7a740de..a010debb4 100644 --- a/test/replication/gh-4730-applier-rollback.test.lua +++ b/test/replication/gh-4730-applier-rollback.test.lua @@ -12,7 +12,7 @@ box.schema.user.grant('guest', 'replication') -- -- Create replica instance, we're the master and -- start it, no data to sync yet though -test_run:cmd("create server replica_slave with rpl_master=default, script='replication/replica-applier-rollback.lua'") +test_run:cmd("create server replica_slave with rpl_master=default, script='replication/replica.lua'") test_run:cmd("start server replica_slave") -- diff --git a/test/replication/replica-applier-rollback.lua b/test/replication/replica-applier-rollback.lua deleted file mode 100644 index 26fb10055..000000000 --- a/test/replication/replica-applier-rollback.lua +++ /dev/null @@ -1,16 +0,0 @@ --- --- vim: ts=4 sw=4 et --- - -print('arg', arg) - -box.cfg({ - replication = os.getenv("MASTER"), - listen = os.getenv("LISTEN"), - memtx_memory = 107374182, - replication_timeout = 0.1, - replication_connect_timeout = 0.5, - read_only = true, -}) - -require('console').listen(os.getenv('ADMIN')) -- 2.24.3 (Apple Git-128)
next prev parent reply other threads:[~2021-06-11 21:59 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-11 21:56 [Tarantool-patches] [PATCH 00/13] Applier rollback reason Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 01/13] error: introduce ER_CASCADE_ROLLBACK Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 10/13] txn: install proper diag errors on txn fail Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 11/13] wal: introduce JOURNAL_ENTRY_ERR_CASCADE Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 12/13] txn: introduce TXN_SIGNATURE_ABORT Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 13/13] txn: stop TXN_SIGNATURE_ABORT override Vladislav Shpilevoy via Tarantool-patches 2021-06-15 13:44 ` Serge Petrenko via Tarantool-patches 2021-06-15 19:34 ` Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` Vladislav Shpilevoy via Tarantool-patches [this message] 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 03/13] journal: make journal_write() set diag on error Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 04/13] wal: refactor wal_write_to_disk() Vladislav Shpilevoy via Tarantool-patches 2021-06-15 20:46 ` Cyrill Gorcunov via Tarantool-patches 2021-06-16 6:22 ` Vladislav Shpilevoy via Tarantool-patches 2021-06-16 8:02 ` Cyrill Gorcunov via Tarantool-patches 2021-06-16 23:32 ` Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 05/13] diag: introduce diag_set_detailed() Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 06/13] wal: encapsulate ER_WAL_IO Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 07/13] txn: change limbo rollback check in the trigger Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 08/13] journal: introduce proper error codes Vladislav Shpilevoy via Tarantool-patches 2021-06-11 21:56 ` [Tarantool-patches] [PATCH 09/13] txn: assert after WAL write that txn is not done Vladislav Shpilevoy via Tarantool-patches 2021-06-15 13:43 ` [Tarantool-patches] [PATCH 00/13] Applier rollback reason Serge Petrenko via Tarantool-patches 2021-06-16 23:32 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=69c1012338d9e08fca08ea99b6f8d8c13205d289.1623448465.git.v.shpilevoy@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 02/13] test: remove replica-applier-rollback.lua' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox