From: Igor Munkin via Tarantool-discussions <tarantool-discussions@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-discussions@dev.tarantool.org
Subject: Re: [Tarantool-discussions] [RFC luajit v3] rfc: describe a LuaJIT memory profiler
Date: Thu, 21 Jan 2021 21:41:45 +0300 [thread overview]
Message-ID: <20210121184145.GA27620@tarantool.org> (raw)
In-Reply-To: <20210120081957.GA3034@root>
Sergey,
Thanks for the fixes, LGTM.
On 20.01.21, Sergey Kaplun wrote:
> Hi, Igor!
>
> Thanks for the review!
>
> On 15.01.21, Igor Munkin wrote:
> > Sergey,
> >
> > Thanks for the changes. There is a bit of nitpicking below and I
> > believe we'll push the next version doc to the trunk.
>
> I've fixed all your comments, plus added some insignificant fixes.
> See two iterative patches below. Branch is force pushed.
Great, thanks! I also changed the commit subject to the following:
| rfc: describe a LuaJIT memory profiler toolchain
>
> >
> > On 25.12.20, Sergey Kaplun wrote:
> > > Part of #5442
> > > ---
> > >
> > > RFC on branch: https://github.com/tarantool/tarantool/blob/skaplun/gh-5442-luajit-memory-profiler/doc/rfc/5442-luajit-memory-profiler.md
>
> Side note: branch name is updated.
> New RFC version: https://github.com/tarantool/tarantool/blob/skaplun/gh-5442-luajit-memory-profiler-rfc/doc/rfc/5442-luajit-memory-profiler.md
>
> > >
> > > Changes in v3:
> > > * More comments in example.
> > > * More verbose benchmark information.
> > > * Grammar and spelling fixes.
> > >
> > > Changes in v2:
> > > * Removed C API, Tarantool integration and description of additional
> > > features -- they will be added in another RFC if necessary.
> > > * Removed checking profile is running from the public API.
> > > * Added benchmarks and more meaningful example.
> > > * Grammar fixes.
> > >
> > > doc/rfc/5442-luajit-memory-profiler.md | 314 +++++++++++++++++++++++++
> > > 1 file changed, 314 insertions(+)
> > > create mode 100644 doc/rfc/5442-luajit-memory-profiler.md
> > >
<snipped>
> --
> Best regards,
> Sergey Kaplun
--
Best regards,
IM
next prev parent reply other threads:[~2021-01-21 18:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 11:34 Sergey Kaplun
2021-01-15 13:14 ` Igor Munkin via Tarantool-discussions
2021-01-20 8:19 ` Sergey Kaplun via Tarantool-discussions
2021-01-20 14:26 ` Sergey Ostanevich via Tarantool-discussions
2021-01-20 14:57 ` Sergey Kaplun via Tarantool-discussions
2021-01-21 18:41 ` Igor Munkin via Tarantool-discussions [this message]
2021-01-21 18:42 ` Igor Munkin via Tarantool-discussions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121184145.GA27620@tarantool.org \
--to=tarantool-discussions@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-discussions] [RFC luajit v3] rfc: describe a LuaJIT memory profiler' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox