From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E9C0081F5C; Thu, 21 Jan 2021 21:41:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9C0081F5C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611254511; bh=jYaiZ0w5rfES8g9iNgpUxhMRBvOQ3BikfglbqwWEC08=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NBJ2mCKWZNzX6p/uriNh3/Rv8uY+G0VMPwbGJBhQIDOsSIvazKDYFap5s7bD7vzrs 4G5seWCTnxMfEf2xVxVfWUE+Y2iZsTiDuEU9ZorWdYY6JDvtt3n+pPuFkggN9PjQzv Riyx/M+UWSGYlnvhM8jShzOlrpyDwSZdSSIlIgO4= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8674C686FA for ; Thu, 21 Jan 2021 21:41:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8674C686FA Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l2etw-0002nr-Dk; Thu, 21 Jan 2021 21:41:48 +0300 Date: Thu, 21 Jan 2021 21:41:45 +0300 To: Sergey Kaplun Message-ID: <20210121184145.GA27620@tarantool.org> References: <20201225113431.9538-1-skaplun@tarantool.org> <20210115131424.GA5460@tarantool.org> <20210120081957.GA3034@root> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210120081957.GA3034@root> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9FAB20BF8F075903611E4AAC87D4D1F5ADD85E7A24115F22B182A05F538085040C16E7A28A5F46DEEF071B1D9259D672B6A44A74A4C3DE0813BA894D0091058B9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CA8E915ACC910FBDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376A27C8034CCD05E58638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC6E16FA89203B2AC725730C0FAD363B4052520D6601A18EC0389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A633E4711A430BBE8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D52CD31C43BF465FCC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCDB6CDAEC4BC593EA75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4931B544F03EFBC4D57F67BA0E7924E9B8DC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A59D2149630FD1D4D55FA800524548059A88599EBF7945B77ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754DBC578B17CB11D78E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344F2126FF337FA651D91F7F06FAD2732CF6FBF7AC319B180FFFF1886D4089646B6B1759283A441E5A1D7E09C32AA3244C29DE6AA26A917045D0C6024C98DBF6BC259227199D06760A927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYT//mZRaUehh1TczWgekzQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822FDE40A5BF82D3CA952134254DC9ED8D6A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-discussions] [RFC luajit v3] rfc: describe a LuaJIT memory profiler X-BeenThere: tarantool-discussions@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development process List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-discussions Reply-To: Igor Munkin Cc: tarantool-discussions@dev.tarantool.org Errors-To: tarantool-discussions-bounces@dev.tarantool.org Sender: "Tarantool-discussions" Sergey, Thanks for the fixes, LGTM. On 20.01.21, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the review! > > On 15.01.21, Igor Munkin wrote: > > Sergey, > > > > Thanks for the changes. There is a bit of nitpicking below and I > > believe we'll push the next version doc to the trunk. > > I've fixed all your comments, plus added some insignificant fixes. > See two iterative patches below. Branch is force pushed. Great, thanks! I also changed the commit subject to the following: | rfc: describe a LuaJIT memory profiler toolchain > > > > > On 25.12.20, Sergey Kaplun wrote: > > > Part of #5442 > > > --- > > > > > > RFC on branch: https://github.com/tarantool/tarantool/blob/skaplun/gh-5442-luajit-memory-profiler/doc/rfc/5442-luajit-memory-profiler.md > > Side note: branch name is updated. > New RFC version: https://github.com/tarantool/tarantool/blob/skaplun/gh-5442-luajit-memory-profiler-rfc/doc/rfc/5442-luajit-memory-profiler.md > > > > > > > Changes in v3: > > > * More comments in example. > > > * More verbose benchmark information. > > > * Grammar and spelling fixes. > > > > > > Changes in v2: > > > * Removed C API, Tarantool integration and description of additional > > > features -- they will be added in another RFC if necessary. > > > * Removed checking profile is running from the public API. > > > * Added benchmarks and more meaningful example. > > > * Grammar fixes. > > > > > > doc/rfc/5442-luajit-memory-profiler.md | 314 +++++++++++++++++++++++++ > > > 1 file changed, 314 insertions(+) > > > create mode 100644 doc/rfc/5442-luajit-memory-profiler.md > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM