[Tarantool-patches] [PATCH luajit 2/2] Only emit proper parent references in snapshot replay.

Sergey Bronnikov sergeyb at tarantool.org
Thu Feb 8 17:12:28 MSK 2024


Hi, Sergey

(spoiler - LGTM)

On 2/6/24 14:41, Sergey Kaplun wrote:
> On 06.02.24, Sergey Bronnikov wrote:
>> On 2/6/24 13:07, Sergey Kaplun wrote:
>>> Hi, Sergey!
>>> Thanks for the review!
>>>
>>> On 06.02.24, Sergey Bronnikov wrote:
>>>> Hi, Sergey
>>>>
>>>> thanks for the patch! test is passed with reverted patch.
> Do you revert only this patch or the previous one too (or run just on
> the cloned master)?
> Because without the previous patch (1/2), the repro doesn't work.
>
> I've tried this flags locally and test is failed as expeced for GC64 and
> non-GC64 builds.
>
>
Seems it was a problem on my side (probably forgot to stash patch after 
`git reset`).

The problem is reproduced by test, luajit is crashed with segmentation 
fault.

Patch LGTM, thanks!


<snipped>



More information about the Tarantool-patches mailing list