[Tarantool-patches] [PATCH luajit 2/2] Only emit proper parent references in snapshot replay.

Sergey Kaplun skaplun at tarantool.org
Tue Feb 6 14:41:07 MSK 2024


On 06.02.24, Sergey Bronnikov wrote:
> 
> On 2/6/24 13:07, Sergey Kaplun wrote:
> > Hi, Sergey!
> > Thanks for the review!
> >
> > On 06.02.24, Sergey Bronnikov wrote:
> >> Hi, Sergey
> >>
> >> thanks for the patch! test is passed with reverted patch.

Do you revert only this patch or the previous one too (or run just on
the cloned master)?
Because without the previous patch (1/2), the repro doesn't work.

I've tried this flags locally and test is failed as expeced for GC64 and
non-GC64 builds.

> >>
> >>
> >> cmake -S . -B build -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
> >>
> >> cmake --builddir  build
> >>
> >> cmake --builddir build -t LuaJIT-tests
> > CMake may cache LUAJIT_USE_SYSMALLOC flag, and test may not fail without
> > it. Was this flag set?
> >
> only  -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON were used, see above
> 

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list