[Tarantool-patches] [PATCH luajit v3] sysprof: fix crash during FFUNC stream

[Sergey Bronnikov]

Hi, Max

sorry for a delayed answer.

LGTM with a minor comment


On 7/14/23 17:30, Maxim Kokryashkin wrote:
>
<snipped>
>
>
>     > +end
>     > +
>     > +res, err = misc.sysprof.stop()
>     > +assert(res, err)
>     > +
>     > +test:ok(true, 'sysprof finished successfully')
>
I propose to reflect a goal of the test in a test description. Please 
add something about ffunc to description.

The test is not about whole sysprof, but about ffunc support in sysprof.

>     > +
>     > +os.exit(test:check() and 0 or 1)
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20231108/382c0502/attachment.htm>