<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi, Max</p>
<p>sorry for a delayed answer.</p>
<p>LGTM with a minor comment<br>
</p>
<p><br>
</p>
<div class="moz-cite-prefix">On 7/14/23 17:30, Maxim Kokryashkin
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:1689345019.547057052@f380.i.mail.ru">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div>
<div><br>
</div>
</div>
</blockquote>
<snipped><br>
<blockquote type="cite"
cite="mid:1689345019.547057052@f380.i.mail.ru">
<div>
<div>
<div> </div>
</div>
</div>
<blockquote
style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
<div>
<div class="js-helper js-readmsg-msg">
<div>
<div><br>
> +end<br>
> +<br>
> +res, err = misc.sysprof.stop()<br>
> +assert(res, err)<br>
> +<br>
> +test:ok(true, 'sysprof finished successfully')<br>
</div>
</div>
</div>
</div>
</blockquote>
</blockquote>
<p>I propose to reflect a goal of the test in a test description.
Please add something about ffunc to description.</p>
<p>The test is not about whole sysprof, but about ffunc support in
sysprof.<br>
</p>
<blockquote type="cite"
cite="mid:1689345019.547057052@f380.i.mail.ru">
<blockquote
style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
<div>
<div class="js-helper js-readmsg-msg">
<div>
<div>> +<br>
> +os.exit(test:check() and 0 or 1)</div>
</div>
</div>
</div>
</blockquote>
<br>
</blockquote>
</body>
</html>