[Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper

Igor Munkin imun at tarantool.org
Tue Jan 10 14:12:13 MSK 2023


Sergey,

Thanks for your review!

On 10.01.23, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch!
> LGTM!

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun at tarantool.org>

> 

<snipped>

> > (*) Max, could you please check this patch on the Alpine?
> 
> Should we add the Alpine build and test in our CI in the scope of this
> commit or with separate one?

Honestly, I don't want to make LuaJIT CI similar to Tarantool one in
this context: if you commit to support the Linux-based distro zoo in our
CI, feel free to extend it by yourself. I'd rather introduce FreeBSD (or
another BSD distro) instead of another fancy Linux with little tweaks
that differ it from the popular ones.

> 

<snipped>

> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list