[Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper
Sergey Kaplun
skaplun at tarantool.org
Tue Jan 10 13:05:25 MSK 2023
Hi, Igor!
Thanks for the patch!
LGTM!
On 09.01.23, Igor Munkin wrote:
> After struggling with black voodoo magic oneliner provided by Mike Pall
> in scope of e131936133c58de4426c595db2341caf5a1665b5 ("Cleanup and
> enable external unwinding for more platforms.") to check whether the
> target toolchain always generates unwind tables, it was decided to
> implement it as a CMake function to encapsulate and comment this damn
> "grep" spell.
>
> Signed-off-by: Igor Munkin <imun at tarantool.org>
> ---
>
> Branch: https://github.com/tarantool/luajit/compare/imun/fix-build-for-non-bash
> CI is green(*): https://github.com/tarantool/luajit/commit/e717eaa
>
> (*) Max, could you please check this patch on the Alpine?
Should we add the Alpine build and test in our CI in the scope of this
commit or with separate one?
>
> cmake/CheckUnwindTables.cmake | 114 ++++++++++++++++++++++++++++++++++
> cmake/SetTargetFlags.cmake | 18 ++----
> 2 files changed, 120 insertions(+), 12 deletions(-)
> create mode 100644 cmake/CheckUnwindTables.cmake
>
> diff --git a/cmake/CheckUnwindTables.cmake b/cmake/CheckUnwindTables.cmake
> new file mode 100644
> index 00000000..903977ad
> --- /dev/null
> +++ b/cmake/CheckUnwindTables.cmake
<snipped>
> diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake
> index 1ca438f1..3b9e481d 100644
> --- a/cmake/SetTargetFlags.cmake
> +++ b/cmake/SetTargetFlags.cmake
<snipped>
> --
> 2.34.0
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list